Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StackFrame Parser/Lexer as EmbeddedLanguage #56957

Merged
merged 62 commits into from
Nov 5, 2021
Merged

StackFrame Parser/Lexer as EmbeddedLanguage #56957

merged 62 commits into from
Nov 5, 2021

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Oct 5, 2021 •
edited
Loading

Implement the Parser/Lexer for StackFrame to use with StackFrame Explorer. This is not currently hooked up to the implementation of StackTrace Explorer. For now this is to just finalize on what the output tree will look like and add parsing tests to exercise the inputs.

@jmarolf
Copy link
Contributor

jmarolf commented Oct 5, 2021

while this is still a draft :) I would apprreciate @CyrusNajmabadi taking a look see if he agrees with the direction.

@ryzngard
Copy link
Contributor Author

ryzngard commented Oct 5, 2021

while this is still a draft :) I would apprreciate @CyrusNajmabadi taking a look see if he agrees with the direction.

Agree, I talked offline with him a bit. I'm going to do some cleanup/documentation of current implementation so far in the next commit. I think that will be a good time to start looking.

@runfoapp runfoapp bot mentioned this pull request Nov 3, 2021
Closed
@ryzngard ryzngard enabled auto-merge (squash) November 4, 2021 01:46
@ryzngard
Copy link
Contributor Author

ryzngard commented Nov 4, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@ryzngard ryzngard merged commit d3d009d into dotnet:main Nov 5, 2021
@ghost ghost added this to the Next milestone Nov 5, 2021
@ryzngard ryzngard deleted the features/stackframe_parser branch November 5, 2021 04:59
@JoeRobich
Copy link
Member

🎉

333fred added a commit to 333fred/roslyn that referenced this pull request Nov 8, 2021
@333fred
Merge remote-tracking branch 'upstream/main' into ref-unmanagedcaller…
6b82e22 
…sonly

* upstream/main: (829 commits)
  Re-enable BuildWithCommandLine test (dotnet#57584)
  Fix expected formatting in tests
  Simplify
  PR feedback
  Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571)
  Less linq
  Revert
  Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb
  Add test
  Simplify
  WIP
  Install .NET SDK in PR Validation pipeline
  Revert to VS2019 for PR Validation
  Update dependencies from https://github.com/dotnet/roslyn build 20211103.8
  Validate the checksum of source on disk (dotnet#57541)
  Clean up VsCodeWindowManager (dotnet#57582)
  Update VS editor package version
  Revert to VS2019 for official build
  Revert to VS2019 for official build
  StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957)
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Nov 8, 2021
@333fred
Merge remote-tracking branch 'upstream/main' into lifted-nullable-ref…
3488a33 
…-struct

* upstream/main: (829 commits)
  Re-enable BuildWithCommandLine test (dotnet#57584)
  Fix expected formatting in tests
  Simplify
  PR feedback
  Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571)
  Less linq
  Revert
  Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb
  Add test
  Simplify
  WIP
  Install .NET SDK in PR Validation pipeline
  Revert to VS2019 for PR Validation
  Update dependencies from https://github.com/dotnet/roslyn build 20211103.8
  Validate the checksum of source on disk (dotnet#57541)
  Clean up VsCodeWindowManager (dotnet#57582)
  Update VS editor package version
  Revert to VS2019 for official build
  Revert to VS2019 for official build
  StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957)
  ...
@allisonchou allisonchou modified the milestones: Next, 17.1.P2 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@jmarolf jmarolf jmarolf left review comments

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.1.P2
Development

Successfully merging this pull request may close these issues.
5 participants
@ryzngard @jmarolf @CyrusNajmabadi @JoeRobich @allisonchou