-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't crash Use ExpressionBody on local functions in top level statements #57571
Merged
davidwengier
merged 4 commits into
dotnet:main
from
davidwengier:FixUseExpressionBodyCrash
Nov 5, 2021
Merged
Don't crash Use ExpressionBody on local functions in top level statements #57571
davidwengier
merged 4 commits into
dotnet:main
from
davidwengier:FixUseExpressionBodyCrash
Nov 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...lyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyForLocalFunctionHelper.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/CodeFixes/UseExpressionBody/UseExpressionBodyCodeFixProvider.cs
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
CyrusNajmabadi
approved these changes
Nov 5, 2021
ghost
added this to the Next milestone
Nov 5, 2021
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 8, 2021
…sonly * upstream/main: (829 commits) Re-enable BuildWithCommandLine test (dotnet#57584) Fix expected formatting in tests Simplify PR feedback Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571) Less linq Revert Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb Add test Simplify WIP Install .NET SDK in PR Validation pipeline Revert to VS2019 for PR Validation Update dependencies from https://github.com/dotnet/roslyn build 20211103.8 Validate the checksum of source on disk (dotnet#57541) Clean up VsCodeWindowManager (dotnet#57582) Update VS editor package version Revert to VS2019 for official build Revert to VS2019 for official build StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957) ...
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 8, 2021
…-struct * upstream/main: (829 commits) Re-enable BuildWithCommandLine test (dotnet#57584) Fix expected formatting in tests Simplify PR feedback Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571) Less linq Revert Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb Add test Simplify WIP Install .NET SDK in PR Validation pipeline Revert to VS2019 for PR Validation Update dependencies from https://github.com/dotnet/roslyn build 20211103.8 Validate the checksum of source on disk (dotnet#57541) Clean up VsCodeWindowManager (dotnet#57582) Update VS editor package version Revert to VS2019 for official build Revert to VS2019 for official build StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957) ...
jmarolf
pushed a commit
to jmarolf/roslyn
that referenced
this pull request
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57570