Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable BuildWithCommandLine test #57584

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Conversation

allisonchou
Copy link
Contributor

@allisonchou allisonchou commented Nov 4, 2021

This test was previously disabled for being flaky. This flakiness has been resolved with this PR, which allows us to re-enable the test.

Fixes #18204

@allisonchou allisonchou requested a review from a team as a code owner November 4, 2021 20:39
@allisonchou allisonchou added the Test Test failures in roslyn-CI label Nov 4, 2021
@allisonchou allisonchou merged commit 7696467 into main Nov 8, 2021
@ghost ghost added this to the Next milestone Nov 8, 2021
333fred added a commit to 333fred/roslyn that referenced this pull request Nov 8, 2021
…sonly

* upstream/main: (829 commits)
  Re-enable BuildWithCommandLine test (dotnet#57584)
  Fix expected formatting in tests
  Simplify
  PR feedback
  Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571)
  Less linq
  Revert
  Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb
  Add test
  Simplify
  WIP
  Install .NET SDK in PR Validation pipeline
  Revert to VS2019 for PR Validation
  Update dependencies from https://github.com/dotnet/roslyn build 20211103.8
  Validate the checksum of source on disk (dotnet#57541)
  Clean up VsCodeWindowManager (dotnet#57582)
  Update VS editor package version
  Revert to VS2019 for official build
  Revert to VS2019 for official build
  StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957)
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Nov 8, 2021
…-struct

* upstream/main: (829 commits)
  Re-enable BuildWithCommandLine test (dotnet#57584)
  Fix expected formatting in tests
  Simplify
  PR feedback
  Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571)
  Less linq
  Revert
  Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb
  Add test
  Simplify
  WIP
  Install .NET SDK in PR Validation pipeline
  Revert to VS2019 for PR Validation
  Update dependencies from https://github.com/dotnet/roslyn build 20211103.8
  Validate the checksum of source on disk (dotnet#57541)
  Clean up VsCodeWindowManager (dotnet#57582)
  Update VS editor package version
  Revert to VS2019 for official build
  Revert to VS2019 for official build
  StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957)
  ...
@sharwell sharwell deleted the dev/allichou/ReenableTest branch November 10, 2021 23:53
allisonchou added a commit to allisonchou/roslyn that referenced this pull request Nov 11, 2021
@allisonchou allisonchou modified the milestones: Next, 17.1.P2 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Test Test failures in roslyn-CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky Test] Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpBuild.BuildWithCommandLine Test Failure
5 participants