BackgroundAnalysisScope enhancements #57172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses first two parts of dotnet#57146
ghost
added
the
mavasani
commented
Oct 15, 2021
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Show resolved
Hide resolved
… ActiveFile background analysis scope is enabled. This is required because a top level change in ActiveFile mode would have cleared all analyzer diagnostics for non-active documents and persisted empty diagnostics state for those documents, and we need to reset that state on active document changed to ensure up-to-date analyzer diagnostics are shown for newly active document.
mavasani
commented
Oct 19, 2021
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Outdated
Show resolved
Hide resolved
mavasani
changed the title
|
@dotnet/roslyn-ide Ping for reviews. |
How does this surface to the user? |
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Show resolved
Hide resolved
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Show resolved
Hide resolved
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Outdated
Show resolved
Hide resolved
...es/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnosticsForSpan.cs
Outdated
Show resolved
Hide resolved
...ures/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs
Show resolved
Hide resolved
...ures/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs
Show resolved
Hide resolved
...ures/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/SolutionCrawler/IncrementalAnalyzerBase.cs
Outdated
Show resolved
Hide resolved
sharwell
dismissed
their stale review
Will remove Razor workarounds in immediate follow-up
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Outdated
Show resolved
Hide resolved
…ementalAnalyzer.Executor.cs Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
…ementalAnalyzer.Executor.cs Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
…ementalAnalyzer.Executor.cs Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
|
@CyrusNajmabadi @sharwell All comments should be addressed now. Thanks! |
This was referenced Jan 31, 2022
Closed
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Outdated
Show resolved
Hide resolved
...ures/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs
Outdated
Show resolved
Hide resolved
|
I'm likely ok with this if Sam is ok :) |
CyrusNajmabadi
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
I'm signing off. But this needs a second signoff from @sharwell :)
sharwell
approved these changes
Feb 10, 2022
src/Features/Core/Portable/SolutionCrawler/AggregateIncrementalAnalyzer.cs
Show resolved
Hide resolved
src/Features/Core/Portable/SolutionCrawler/WorkCoordinator.IncrementalAnalyzerProcessor.cs
Outdated
Show resolved
Hide resolved
...ures/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs
Show resolved
Hide resolved
ryzngard
added
UX Review Not Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57146
BackgroundAnalysisScope.Nonefor compiler diagnostics only editing experience.BackgroundAnalysisScope.ActiveFileso we execute compiler analyzer for all open files and remaining analyzers for the active file.BackgroundAnalysisScope.ActiveFileto be the default scope. We will turn this experiment on for Roslyn team to enable dogfooding the experience with the new mode.[Still under discussion] A separate follow-up PR will add an experiment to switchBackgroundAnalysisScope.ActiveFileto be the default scope.