Add test from PR 50799 for impl PR 56853 #57752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implemented as part of dotnet#50799 and later realized via dotnet#56853
ghost
added
the
Community
src/Compilers/CSharp/Test/Syntax/Parsing/ExpressionParsingTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Syntax/Parsing/ExpressionParsingTests.cs
Outdated
Show resolved
Hide resolved
|
The test-error has nothing to do with this PR.... |
333fred
reviewed
Nov 15, 2021
src/Compilers/CSharp/Test/Syntax/Parsing/ExpressionParsingTests.cs
Outdated
Show resolved
Hide resolved
333fred
approved these changes
Nov 16, 2021
|
@CyrusNajmabadi @dotnet/roslyn-compiler for another review. |
|
@CyrusNajmabadi could you have another look? |
CyrusNajmabadi
approved these changes
Dec 9, 2021
|
Thanks @bernd5! Sorry it took a bit to get this merged, we had some infra troubles the past week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR #56853 we got support for new lines in string interpolations holes. That PR has some semantic and error tests (for C# < 11) but no syntax test. Therefore I would like to add the test from the closed PR #50799.