-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial work to move indentation services down to codestyle layer (step 4/N) #60442
Conversation
...ces/SharedUtilitiesAndExtensions/Compiler/CSharp/Formatting/CSharpSyntaxFormattingService.cs
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Indentation/FormattingOptions.IndentStyle.cs
Show resolved
Hide resolved
...aces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/FormattingOptions2.IndentStyle.cs
Show resolved
Hide resolved
...Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/ISyntaxFormattingService.cs
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Indentation/IndentationOptions.cs
Show resolved
Hide resolved
src/Workspaces/VisualBasic/Portable/Formatting/VisualBasicSyntaxFormattingService.vb
Show resolved
Hide resolved
src/Workspaces/VisualBasic/Portable/Microsoft.CodeAnalysis.VisualBasic.Workspaces.vbproj
Show resolved
Hide resolved
...ces/SharedUtilitiesAndExtensions/Compiler/Core/Formatting/AbstractSyntaxFormattingService.cs
Show resolved
Hide resolved
...ces/SharedUtilitiesAndExtensions/Compiler/CSharp/Formatting/CSharpSyntaxFormattingService.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mostly nits.
Every time i try to tackle the general problem, it explodes into a ton of changes.
I can feel your pain, I ran into the same things when trying to move analyzers/fixers down to these shared layers. Thanks for breaking it up into different PRs!
yup yup. i had to do it in tiny bits. but it all worked out in the end. |
Followup to #60440
This continues that work by pushing ISmartTokenFormatter down to the codestyle layer.
I'm doing these PRs in multiple parts to make things simpler to review. Every time i try to tackle the general problem, it explodes into a ton of changes.
The reason for this change overall is that we have fixers taht need to know indentation information. For example, the 'convert to file-scoped-namespace (and reverse)' fixes have to know indentation information so it can make the right fixes. Not having indentation info be available at thsi level means that the fixes are constrained to the VS host.