Merge 'dotnet/main' into PrimaryConstructors #66364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…216.1 (dotnet#66058) [main] Update dependencies from dotnet/arcade
…uild 20221219.1 (dotnet#66075) [main] Update dependencies from dotnet/roslyn-analyzers
…sedOptions = false`, i.e. disabled by default analyzer is enabled with SpecificDiagnosticOptions
Ensure that the code in analyzer driver that checks if disabled by default analyzer is enabled for a specific tree checks for configuration through CompilationOptions.SpecificDiagnosticOptions. These options can be set through ruleset file or via API in test scenarios, so we need to ensure they are respected.
…a DAG, do that for the the pattern with any 'not's removed, as consumers expect. (dotnet#65878) Use the inner pattern to recreate the decision DAG for is-expressions Fixes dotnet#65876
…et#66311) The check that we used to detect value types at runtime didn’t quite work for nullable value types due to special boxing behavior for them. Switching to `typeof(T).IsValueType` check instead. Fixes dotnet#66162. Related to dotnet#63221.
Fix cancellation in test
Support task list priorities in LSP
Move couple of tests to new testing library
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Add a InternalsVisibleTo for Workspaces.MSBuild
…-handing-of-references-not-yet-added Simplify and fix handing of references not yet added
…net#65831) * Initial experimental API project - Add host outputs to exerimental API surface - Enable internal hosts outputs in generator driver * Move project, add nuget package, add to sln * PR Feedback * Update unreachable calls * Update nullability * Suppress unused parameter warning * Add project to `Compilers.slnf` * Move to new ExternalAccess project * Remove an old IVT * Add project to compiler solutions * Assign project to Roslyn compiler team Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com>
Previously the dialog would dismiss if it no longer had focus. While I had good intentions, there are far too many cases where focus can temporarily change. Instead of trying to handle them all, let's let users go wild. Now it takes an explicit action from the user, or typing outside of a field correlating to the identifier (similar to previous rename). Fixes AB#1705938
jcouv
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66046