Don't overwrite binary logs in CI #66683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it an error whenever we overwrite a binary log during CI. Doing so means we've lost one of our main tools for investigating build failures. Turning this into an error so we don't make the mistake again.
|
@dotnet/roslyn-infrastructure PTAL |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
RikkiGibson
approved these changes
Feb 3, 2023
This was referenced Feb 3, 2023
ghost
added this to the
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Feb 6, 2023
* upstream/main: (547 commits) Add VerifyMethodBody helper as a replacement of VerifyIL (dotnet#66536) don't offer rename for ctor snippet (dotnet#66704) Get `ConditionalAttribute` type only once per compilation Convert language-specific option types to records (dotnet#66633) Enable MSBuild COMM log (dotnet#66708) ⚡️Share AssemblyloadTestFixture on Framework (dotnet#66684) NRT Don't overwrite binary logs in CI (dotnet#66683) Fix 'Generate Enum Member' to work in a 'Color Color' case. Find bitwise operators accessed through logical operators in FAR Semantic snippets - `propg` and `propi` snippets (dotnet#65979) NRT Properly classify aliases in quick info Fix Add tests Add support for finding collection initialiers with FAR Do not suggest replacing lambda with method group if the invoked mehod has `Conditional` attribute Revert "Record added node output states as new (dotnet#61575)" (dotnet#66696) Record added node output states as new (dotnet#61575) Fix formatting issue with convert-to-full-prop ...
dibarbet
pushed a commit
that referenced
this pull request
Apr 19, 2023
* Don't overwrite binary logs in CI This will make it an error whenever we overwrite a binary log during CI. Doing so means we've lost one of our main tools for investigating build failures. Turning this into an error so we don't make the mistake again. * actually fail * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it an error whenever we overwrite a binary log during CI. Doing so means we've lost one of our main tools for investigating build failures. Turning this into an error so we don't make the mistake again.