Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Record added node output states as new" #66696

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Feb 3, 2023

Reverts #61575 - it broke CI

@jjonescz jjonescz marked this pull request as ready for review February 3, 2023 15:43
@jjonescz jjonescz requested a review from a team as a code owner February 3, 2023 15:43
@jaredpar
Copy link
Member

jaredpar commented Feb 3, 2023

Force merging since this is fixing an issue that has CI on the floor. Change has gotten far enough that we know it's working.

@jaredpar jaredpar merged commit 391d367 into main Feb 3, 2023
@ghost ghost added this to the Next milestone Feb 3, 2023
@jjonescz jjonescz deleted the revert-61575-fix-run-step-added-outputs branch February 3, 2023 17:02
333fred added a commit to 333fred/roslyn that referenced this pull request Feb 6, 2023
* upstream/main: (547 commits)
  Add VerifyMethodBody helper as a replacement of VerifyIL (dotnet#66536)
  don't offer rename for ctor snippet (dotnet#66704)
  Get `ConditionalAttribute` type only once per compilation
  Convert language-specific option types to records (dotnet#66633)
  Enable MSBuild COMM log (dotnet#66708)
  ⚡️Share AssemblyloadTestFixture on Framework (dotnet#66684)
  NRT
  Don't overwrite binary logs in CI (dotnet#66683)
  Fix 'Generate Enum Member' to work in a 'Color Color' case.
  Find bitwise operators accessed through logical operators in FAR
  Semantic snippets - `propg` and `propi` snippets (dotnet#65979)
  NRT
  Properly classify aliases in quick info
  Fix
  Add tests
  Add support for finding collection initialiers with FAR
  Do not suggest replacing lambda with method group if the invoked mehod has `Conditional` attribute
  Revert "Record added node output states as new (dotnet#61575)" (dotnet#66696)
  Record added node output states as new (dotnet#61575)
  Fix formatting issue with convert-to-full-prop
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 17.6 P2 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants