Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale comments #68557

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #67329

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner June 12, 2023 17:22
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 12, 2023
@CyrusNajmabadi
Copy link
Member Author

@jcouv ptal.

@@ -3732,7 +3732,6 @@ public unsafe static void Main()
}
");

// Support for `using unsafe static` tracked by https://github.com/dotnet/roslyn/issues/67329
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment was about the using static C1<S<C0>*[]>; scenario. Do we have the corresponding test scenario with "unsafe" added?
Same question for using static C1<S<C0>*[]>.E1; below.

@jcouv jcouv added the Test Test failures in roslyn-CI label Jun 13, 2023
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 1)

@jcouv jcouv self-assigned this Jun 13, 2023
@CyrusNajmabadi
Copy link
Member Author

tests added @jcouv .

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 2). Danke schön!

@CyrusNajmabadi CyrusNajmabadi merged commit 445f2c6 into dotnet:main Jun 13, 2023
@CyrusNajmabadi CyrusNajmabadi deleted the staleComments branch June 13, 2023 20:35
@ghost ghost added this to the Next milestone Jun 13, 2023
@RikkiGibson RikkiGibson modified the milestones: Next, 17.7 P3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Test Test failures in roslyn-CI untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add support for using unsafe static <Type>;
4 participants