Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stale comments #68557

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Remove stale comments #68557

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2695745
remove stale comments
CyrusNajmabadi Jun 12, 2023
30217e4
Add tests
CyrusNajmabadi Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Compilers/CSharp/Test/Symbol/Compilation/UsedAssembliesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3732,7 +3732,6 @@ public unsafe static void Main()
}
");

// Support for `using unsafe static` tracked by https://github.com/dotnet/roslyn/issues/67329
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment was about the using static C1<S<C0>*[]>; scenario. Do we have the corresponding test scenario with "unsafe" added?
Same question for using static C1<S<C0>*[]>.E1; below.

verifyDiagnostics(comp0Ref, comp1Ref,
@"
using static C1<S<C0>*[]>;
Expand All @@ -3757,7 +3756,6 @@ public static void Main()
// _ = E1.F1 + 1;
Diagnostic(ErrorCode.ERR_UnsafeNeeded, "E1.F1 + 1").WithLocation(7, 13));

// Support for `using unsafe static` tracked by https://github.com/dotnet/roslyn/issues/67329
verifyDiagnostics(comp0Ref, comp1Ref,
@"
using static C1<S<C0>*[]>.E1;
Expand Down