Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename collection literals to collection expressions #69114

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Rename collection literals to collection expressions #69114

merged 1 commit into from
Jul 20, 2023

Conversation

cston
Copy link
Member

@cston cston commented Jul 19, 2023

No description provided.

@cston cston requested review from a team as code owners July 19, 2023 21:20
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 19, 2023
@jcouv jcouv merged commit 5005650 into dotnet:main Jul 20, 2023
27 checks passed
@ghost ghost added this to the Next milestone Jul 20, 2023
@jcouv
Copy link
Member

jcouv commented Jul 20, 2023 •
edited
Loading

I accidentally merged this prematurely, thinking it was my spec PR of the same name and I'd forgotten to merge it :-/ Reviewing now

jcouv
jcouv reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Jul 20, 2023
@allisonchou allisonchou mentioned this pull request Jul 21, 2023
Closed
@cston cston deleted the collections-rename branch July 24, 2023 18:07
@allisonchou allisonchou modified the milestones: Next, 17.8 P1 Jul 24, 2023
@cston cston mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@333fred 333fred Awaiting requested review from 333fred

@RikkiGibson RikkiGibson Awaiting requested review from RikkiGibson

Assignees

@jcouv jcouv

Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P1
Development

Successfully merging this pull request may close these issues.
4 participants
@cston @jcouv @CyrusNajmabadi @allisonchou