Update PublicAPI for 17.7 #69767
Update PublicAPI for 17.7 #69767
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ghost
added
the
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
| @@ -85,6 +93,7 @@ Microsoft.CodeAnalysis.CSharp.Conversion.Equals(Microsoft.CodeAnalysis.CSharp.Co | |||
| Microsoft.CodeAnalysis.CSharp.Conversion.Exists.get -> bool | |||
| Microsoft.CodeAnalysis.CSharp.Conversion.IsAnonymousFunction.get -> bool | |||
| Microsoft.CodeAnalysis.CSharp.Conversion.IsBoxing.get -> bool | |||
| Microsoft.CodeAnalysis.CSharp.Conversion.IsCollectionLiteral.get -> bool | |||
There was a problem hiding this comment.
@cston Just want to confirm we intend to keep this API name (as opposed to IsCollectionExpression or some such)
There was a problem hiding this comment.
This property was renamed in 17.8 to IsCollectionExpression (see #69114).
There was a problem hiding this comment.
For cases like this, do we just resolve when we ship the 17.8 as a remove/add?
There was a problem hiding this comment.
@cston What do you think of keeping IsCollectionLiteral as unshipped in 17.7?
There was a problem hiding this comment.
This probably needs to be renamed. Unless we also have IsTupleLiteral for the conversion as well.
There was a problem hiding this comment.
What do you think of keeping
IsCollectionLiteralas unshipped in 17.7?
Does that mean, leave IsCollectionLiteral in Public.Unshipped.txt for 17.7? What would that affect?
There was a problem hiding this comment.
You can also mark this as shipped but have a REMOVE line in the unshipped for 17.8. It makes it clearer that it would be a break in that case.
There was a problem hiding this comment.
Either seems fine to me.
Since the collection expressions feature is only in preview in 17.7, it seems fine to leave this API as unshipped. But we can also add it and remove it later...
|
A couple of files show only whitespace/newline changes (LanguageServer/Protocol and RazorCompiler). Can we revert those? |
Done |
No description provided.