Short-circuit tagger usage of interval tree when tagging complete snapshot #70285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pshot Noticed when looking at CPU usage on prism for completion scenario. It looks like the primary culprit that I saw when debugging locally was outlining (TTag was IStructureTag2). I was seeing requests spanning the full snapshot with ~2000 entries in spansToInvalidate when editing in the languageparser.cs file in the Roslyn sln. The Except call would end up creating a 2000 entry set, and proceed to remove all 2000 entries from it. Addresses https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1897704
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| // Performance: No need to fully realize spansToInvalidate or do any of the calculations below if the | ||
| // full snapshot is being invalidated. | ||
| if (firstSpanToInvalidate.Length == firstSpanToInvalidate.Snapshot.Length) | ||
| return Array.Empty<ITagSpan<TTag>>(); |
There was a problem hiding this comment.
fascinating. do we know why the entire span is being invalidated?
There was a problem hiding this comment.
From what I can see, very few of the Roslyn taggers override GetSpansToTag
CyrusNajmabadi
approved these changes
Oct 7, 2023
CyrusNajmabadi
requested changes
Oct 7, 2023
CyrusNajmabadi
approved these changes
Oct 10, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when looking at CPU usage on prism for completion scenario. It looks like the primary culprit that I saw when debugging locally was outlining (TTag was IStructureTag2). I was seeing requests spanning the full snapshot with ~2000 entries in spansToInvalidate when editing in the languageparser.cs file in the Roslyn sln. The Except call would end up creating a 2000 entry set, and proceed to remove all 2000 entries from it.
Fixes AB#1897704