Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-circuit tagger usage of interval tree when tagging complete snapshot #70285

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Short-circuit tagger usage of interval tree when tagging complete snapshot #70285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e0e2e8
Short-circuit tagger usage of interval tree when tagging complete sna…
ToddGrun Oct 7, 2023
96dfd8b
use the local
ToddGrun Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/EditorFeatures/Core/Tagging/AbstractAsynchronousTaggerProvider.TagSource_ProduceTags.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,13 @@ private ImmutableDictionary<ITextBuffer, TagSpanIntervalTree<TTag>> ComputeNewTa

private IEnumerable<ITagSpan<TTag>> GetNonIntersectingTagSpans(IEnumerable<SnapshotSpan> spansToInvalidate, TagSpanIntervalTree<TTag> oldTagTree)
{
var snapshot = spansToInvalidate.First().Snapshot;
var firstSpanToInvalidate = spansToInvalidate.First();
var snapshot = firstSpanToInvalidate.Snapshot;

// Performance: No need to fully realize spansToInvalidate or do any of the calculations below if the
// full snapshot is being invalidated.
if (firstSpanToInvalidate.Length == snapshot.Length)
return Array.Empty<ITagSpan<TTag>>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fascinating. do we know why the entire span is being invalidated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, very few of the Roslyn taggers override GetSpansToTag


return oldTagTree.GetSpans(snapshot).Except(
spansToInvalidate.SelectMany(oldTagTree.GetIntersectingSpans),
Expand Down