Explicitly use dotnet pwsh in scripts #72341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes our cmd/ps1 scripts to explicitly use `dotnet pwsh` instead of `pwsh`. The former is guaranteed to be in our enlistment as it's installed as a local tool. The latter, while present on most machines including CI, is not guaranteed to be on all developer machines.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
JoeRobich
reviewed
Feb 29, 2024
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
JoeRobich
approved these changes
Feb 29, 2024
JoeRobich
reviewed
Feb 29, 2024
| function Stop-Processes() { | ||
| Write-Host 'Killing running build processes Roslyn style...' | ||
| foreach ($processName in $processesToStopOnExit) { | ||
| Get-Process -Name $processName -ErrorAction SilentlyContinue ? { $_.ProcessId -ne $PID } | Stop-Process |
There was a problem hiding this comment.
Had to look up what ? meant in powershell. For others who don't know, ? is an alias for Where-Object. Meaning it works as a filter here to exclude the running process.
jjonescz
approved these changes
Mar 1, 2024
| $ErrorActionPreference="Stop" | ||
|
|
||
| try { | ||
|
|
There was a problem hiding this comment.
Nit: remove blank line?
Suggested change
|
closing in favor of #72423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our cmd/ps1 scripts to explicitly use
dotnet pwshinstead ofpwsh. The former is guaranteed to be in our enlistment as it's installed as a local tool. The latter, while present on most machines including CI, is not guaranteed to be on all developer machines.