Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log contention issue #72419

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix log contention issue #72419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,6 @@ stages:
- pwsh: |
./eng/generate-compiler-code.ps1 -test -configuration Release
displayName: Generate Syntax Files
condition: or(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['compilerChange'], 'true'))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step takes ~30 seconds to complete and is not part of the longest job for CI. Hence conditionalizing this complicates our CI without making throughput any faster. Removing the conditional to simplify this path.


- pwsh: |
./eng/validate-code-formatting.ps1 -ci -rootDirectory $(Build.SourcesDirectory)\src -includeDirectories Compilers\CSharp\Portable\Generated\, Compilers\VisualBasic\Portable\Generated\, ExpressionEvaluator\VisualBasic\Source\ResultProvider\Generated\
Expand Down
16 changes: 6 additions & 10 deletions eng/validate-rules-missing-documentation.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,26 @@
[CmdletBinding(PositionalBinding=$false)]
param (
[switch]$ci
[switch]$ci = $false
)

Set-StrictMode -version 2.0
$ErrorActionPreference="Stop"


Write-Host "Building Microsoft.CodeAnalysis.Features"
try {
. (Join-Path $PSScriptRoot "build-utils.ps1")
Push-Location $RepoRoot
$prepareMachine = $ci

$projectFilePath = Join-Path $RepoRoot "src\Features\Core\Portable\Microsoft.CodeAnalysis.Features.csproj"
Exec-DotNet "build $projectFilePath -t:GenerateRulesMissingDocumentation -p:RoslynEnforceCodeStyle=false -p:RunAnalyzersDuringBuild=false -p:ContinuousIntegrationBuild=$ci -c Release"

if ($LASTEXITCODE -ne 0) {
Write-Host "Failed with exit code $LASTEXITCODE."
exit $LASTEXITCODE
}
}
catch {
Write-Host "Error verifying rules missing documentation!"
Write-Host $_
Write-Host $_.Exception
Write-Host $_.ScriptStackTrace
$host.SetShouldExit(1)
exit 1
ExitWithExitCode 1
}
finally {
Pop-Location
}