Use ProvideSettingsManifest to specify Unfied Settings registration file #72429
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
Cosifne
force-pushed
the
dev/shech/UnifiedSettings3
branch
from
bb04561 to
7ce82c9
Compare
Cosifne
force-pushed
the
dev/shech/UnifiedSettings3
branch
from
7ce82c9 to
022ed06
Compare
| @@ -18,6 +18,7 @@ | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
| <Content Update=".vsextension/string-resources.json" XlfPreserveFileName="true" /> | |||
| <Content Include="UnifiedSettings/csharpSettings.registration.json" IncludeInVSIX="true" CopyToOutputDirectory="PreserveNewest" /> | |||
There was a problem hiding this comment.
Move the registration file to this project, seem more reasonable to me because let it stays with the package
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
| @@ -192,3 +192,10 @@ | |||
| "Package"="{13C3BBB4-F18F-4111-9F54-A0FB010D9194}" | |||
| "SortPriority"=dword:00000064 | |||
| @="Microsoft Visual C#" | |||
|
|
|||
| // CacheTag value should be changed when registration file changes | |||
There was a problem hiding this comment.
Is it autogenerated? Or does it have to be manually updated each time we add / change / remove a setting?
Manual updating seems problematic
There was a problem hiding this comment.
It needs to be manually updated. But I think from the doc it only affects F5 deployment/Testing.
I learned from @JoshuaBStevens that there is a way to config this to be auto-genereated (There is a VS side PR sample to do this, but it is using internal tasks)
So either, 1. Investigate how to do this publicly. 2. Later when all things are moved to gladstone this could also be auto-generated.
All of these look like another work.
Verified locally works on my machine.
This is the recommended way to specify settings for package.
Another blocking issue: Looks like integration tests need to be run in 17.10 image.Image has been updated