[release/8.0-staging] Fix hwintrinsicChild->isContained() assert (#96388

)

* Fix containment

* Fix naming

* Update src/tests/JIT/Regression/JitBlue/Runtime_90508/Runtime_90508.cs

Co-authored-by: Bruce Forstall <brucefo@microsoft.com>

* better fix

* oops, typo

* clean up

* Update lowerxarch.cpp

* Update Runtime_90508.cs

* Update Runtime_90508.cs

---------

Co-authored-by: EgorBo <egorbo@gmail.com>
Co-authored-by: Bruce Forstall <brucefo@microsoft.com>

src/coreclr/jit/lowerxarch.cpp

@@ -7668,7 +7668,10 @@ bool Lowering::IsContainableHWIntrinsicOp(GenTreeHWIntrinsic* parentNode, GenTre
                     const unsigned expectedSize = genTypeSize(parentNode->TypeGet()) / 2;
                     const unsigned operandSize  = genTypeSize(childNode->TypeGet());
 
-                    supportsGeneralLoads = supportsUnalignedSIMDLoads && (operandSize >= expectedSize);
+                    // For broadcasts we can only optimize constants and memory operands
+                    const bool broadcastIsContainable = childNode->OperIsConst() || childNode->isMemoryOp();
+                    supportsGeneralLoads =
+                        broadcastIsContainable && supportsUnalignedSIMDLoads && (operandSize >= expectedSize);
                     break;
                 }
 

src/tests/JIT/Regression/JitBlue/Runtime_90508/Runtime_90508.cs

@@ -0,0 +1,39 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System.Runtime.CompilerServices;
+using System.Runtime.Intrinsics;
+using System.Runtime.Intrinsics.X86;
+using Xunit;
+
+public class Runtime_90508
+{
+    [MethodImpl(MethodImplOptions.NoInlining)]
+    private static Vector128<double> Test1(Vector128<double> v, double b) =>
+        v + Sse3.MoveAndDuplicate(Vector128.CreateScalarUnsafe(b));
+
+    [MethodImpl(MethodImplOptions.NoInlining)]
+    private static Vector128<double> Test2(Vector128<double> v) =>
+        v + Sse3.MoveAndDuplicate(Vector128.CreateScalarUnsafe(1.0));
+
+    [MethodImpl(MethodImplOptions.NoInlining)]
+    private static Vector128<double> Test3(Vector128<double> v) =>
+        v + Sse3.MoveAndDuplicate(Vector128.Create(1.0));
+
+    [Fact]
+    public static int TestEntryPoint()
+    {
+        if (!Sse3.IsSupported)
+        {
+            return 100;
+        }
+
+        if (Test1(Vector128.Create(42.0), 1).ToString().Equals("<43, 43>") &&
+            Test2(Vector128.Create(42.0)).ToString().Equals("<43, 43>") &&
+            Test3(Vector128.Create(42.0)).ToString().Equals("<43, 43>"))
+        {
+            return 100;
+        }
+        return 101;
+    }
+}

src/tests/JIT/Regression/JitBlue/Runtime_90508/Runtime_90508.csproj

@@ -0,0 +1,8 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <Optimize>True</Optimize>
+  </PropertyGroup>
+  <ItemGroup>
+    <Compile Include="$(MSBuildProjectName).cs" />
+  </ItemGroup>
+</Project>