-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Fix hwintrinsicChild->isContained() assert #96388
[release/8.0-staging] Fix hwintrinsicChild->isContained() assert #96388
Conversation
Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #90556 to release/8.0-staging /cc @EgorBo Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@EgorBo Friendly reminder that Tuesday January 16th 4pm is the Code Complete deadline for the February Release. If all requirements are met, please merge your PR before that date and time to ensure this fix gets included in that Release. |
@jeffschwMSFT, please consider this for approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 8.0.x
Backport of #90556 to release/8.0-staging
/cc @EgorBo
Customer Impact
Certain SIMD patterns may produce garbage values on CPUs with AVX-512 (mostly for unoptimized code). This is regression introduced in .NET 8 by AVX512 work.
There were two issues #96381 (customer reported) and #90508
Minimal repro:
Prints
<42, 43>
while<42, 42>
is expected.Testing
A test is added
Risk
Low. It is a simple fix, and the problem reproduces only on machines with AVX512 and with very specific patterns in Tier 0.