-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Wasm.Build.Tests failing on windows #52843
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThese tests fail on helix/windows and also locally, in different way. On helix:
Local:
|
Sounds like you might be missing the payload for the build support directory, which gets added at https://github.com/dotnet/runtime/blob/main/src/libraries/sendtohelixhelp.proj#L292-L299 .
|
Is there a PR where you are testing this? |
Failed again in runtime 20210527.100 Failed tests:
Error message:
|
this is a different error. I'm working on it. |
@VincentBu fyi #53405 |
@radekdoulik @radical Is this still ongoing? |
Yeah, and we need these enabled on windows. |
I created draft which enables it. It would still need more work as the tests fail locally too. I will try to compare mac run to windows one to see what is going on. |
It uses wrong xunit console runner on windows (.NET core 3.1 instead of .NET 6)
|
@radekdoulik does the build vm have Emscripten installed? |
The image doesn't have it, it is provisioned during the build. |
This is already fixed. We run Wasm.Build.Tests on windows, on CI now. |
These tests fail on helix/windows and also locally, in different way.
On helix:
Local:
The text was updated successfully, but these errors were encountered: