Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Wasm.Build.Tests failing #53405

Closed
radical opened this issue May 28, 2021 · 4 comments · Fixed by #53410
Closed

[wasm] Wasm.Build.Tests failing #53405

radical opened this issue May 28, 2021 · 4 comments · Fixed by #53410
Assignees
@adamsitnik
Labels
arch-wasm WebAssembly architecture blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' disabled-test The test is disabled in source code against the issue
Milestone
6.0.0

Comments

@radical
Copy link
Member

radical commented May 28, 2021 •
edited
Loading

  • Wasm.Build.Tests are failing with
    Wasm.Build.Tests.WasmBuildAppTest.AsyncMain [FAIL]
      System.TypeInitializationException : The type initializer for 'Wasm.Build.Tests.BuildTestBase' threw an exception.
      ---- System.TypeLoadException : Could not load type 'System.IO.DirectoryInfo' from assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
      Stack Trace:
        /_/src/tests/BuildWasmApps/Wasm.Build.Tests/BuildTestBase.cs(123,0): at Wasm.Build.Tests.BuildTestBase.ConfigWithAOTData(Boolean aot)
        /_/src/tests/BuildWasmApps/Wasm.Build.Tests/WasmBuildAppTest.cs(19,0): at Wasm.Build.Tests.WasmBuildAppTest.MainMethodTestData(Boolean aot, RunHost host)
        ----- Inner Stack Trace -----

This commit might be the one responsible:

commit 44f050acc0f7791d6cd7ac772945444912bcf299
Author: Adam Sitnik <adam.sitnik@gmail.com>
Date:   Thu May 27 12:56:30 2021 +0200

    Fold System.IO.FileSystem into CoreLib (#53231)

    * move Queue<T> to System.Private.CoreLib

    * fold System.IO.FileSystem into System.Private.CoreLib

Looking at the checks on the PR #53231, Wasm.Build.Tests were failing.

This is a build before the PR was merged - https://dev.azure.com/dnceng/public/_build/results?buildId=1159218&view=logs&s=96ac2280-8cb4-5df5-99de-dd2da759617d

And this is after: https://dev.azure.com/dnceng/public/_build/results?buildId=1159354&view=logs&j=108d2c4a-8a62-5a58-8dad-8e1042acc93c&t=568f884b-cc12-5fd3-e7fe-790b5ac403f4

@adamsitnik please correct me if I got this wrong
@radical radical added arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels May 28, 2021
@ghost
Copy link

ghost commented May 28, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Wasm.Build.Tests are failing with

This commit might be the one responsible:

commit 44f050acc0f7791d6cd7ac772945444912bcf299
Author: Adam Sitnik <adam.sitnik@gmail.com>
Date:   Thu May 27 12:56:30 2021 +0200

    Fold System.IO.FileSystem into CoreLib (#53231)

    * move Queue<T> to System.Private.CoreLib

    * fold System.IO.FileSystem into System.Private.CoreLib

Looking at the checks on the PR #53231, Wasm.Build.Tests were failing.

This is a build before the PR was merged - https://dev.azure.com/dnceng/public/_build/results?buildId=1159218&view=logs&s=96ac2280-8cb4-5df5-99de-dd2da759617d

And this is after: https://dev.azure.com/dnceng/public/_build/results?buildId=1159354&view=logs&j=108d2c4a-8a62-5a58-8dad-8e1042acc93c&t=568f884b-cc12-5fd3-e7fe-790b5ac403f4

cc @adamsitnik

Author: radical
Assignees: -
Labels:

arch-wasm, blocking-clean-ci, disabled-test
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 28, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

radical added a commit to pavelsavara/runtime that referenced this issue May 28, 2021
@radical
Disable wasm.build.tests failing due to dotnet#53405
6c50a25
@radical radical mentioned this issue May 28, 2021
Closed
@GrabYourPitchforks GrabYourPitchforks mentioned this issue May 28, 2021
Merged
@radical radical mentioned this issue May 28, 2021
Merged
radical pushed a commit that referenced this issue May 28, 2021
@pavelsavara
[wasm][xharness] install development SSL certificate on Helix agent b…
72936ec 
…efore xharness run via SDK or powershell (#53280)

Co-authored-by: Ankit Jain <radical@gmail.com>

Caused by #53180, #53225

- The original approach to install certificates didn't work because we don't have dotnet SDK, just runtime on Helix agents.
- dotnet dev-certs https needs user interaction with a dialog. Instead, using powershelgl to install certs
- Wasm.Build.Tests are being disabled here because of #53405

Fixes #53207
@adamsitnik adamsitnik mentioned this issue May 28, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 28, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 28, 2021
adamsitnik added a commit that referenced this issue May 28, 2021
@adamsitnik
Wasm.Build.Tests should not use local targeting runtime pack, fixes #…
f54a4cd 
…53405 (#53410)
@adamsitnik adamsitnik removed the untriaged New issue has not been triaged by the area owner label May 28, 2021
@adamsitnik adamsitnik self-assigned this May 28, 2021
@adamsitnik adamsitnik added this to the 6.0.0 milestone May 28, 2021
@adamsitnik
Copy link
Member

@radical please excuse me for that. I've merged a fix in #53410

@pavelsavara pavelsavara mentioned this issue May 28, 2021
Closed
radical added a commit to radical/runtime that referenced this issue May 28, 2021
@radical
[wasm] Re-enable Wasm.Build.Tests
9bd060d 
.. as dotnet#53405 is fixed.
@radical radical mentioned this issue May 28, 2021
Merged
@radical
Copy link
Member Author

radical commented May 28, 2021

@adamsitnik no worries. Thanks for the quick fix. I have opened #53433 to re-enable the tests.

@buyaa-n buyaa-n mentioned this issue Jun 1, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamsitnik adamsitnik

Labels
arch-wasm WebAssembly architecture blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Wasm.Build.Tests should not use local targeting runtime pack adamsitnik/runtime
2 participants
@radical @adamsitnik