Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][xharness] install development SSL certificate on Helix agent before xharness run #53180

Merged
merged 1 commit into from
May 24, 2021

Conversation

pavelsavara
Copy link
Member

I added HTTPS listener to existing kestrel server in the xharness last week.
After the change propagated to this repo, I can see following issue on Helix

crit: System.InvalidOperationException: Unable to configure HTTPS endpoint. 
No server certificate was specified, and the default developer certificate could not be found or is out of date. 
To generate a developer certificate run 'dotnet dev-certs https'.

@ghost
Copy link

ghost commented May 24, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

I added HTTPS listener to existing kestrel server in the xharness last week.
After the change propagated to this repo, I can see following issue on Helix

crit: System.InvalidOperationException: Unable to configure HTTPS endpoint. 
No server certificate was specified, and the default developer certificate could not be found or is out of date. 
To generate a developer certificate run 'dotnet dev-certs https'.
Author: pavelsavara
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@pavelsavara pavelsavara marked this pull request as ready for review May 24, 2021 16:04
@ViktorHofer
Copy link
Member

ViktorHofer commented May 26, 2021

Should this issue already be resolved? I'm stilling hitting it in CI:

Connection refused [::ffff:127.0.0.1]:39621 (localhost:39621)
[09:28:01] crit: System.InvalidOperationException: Unable to configure HTTPS endpoint. No server certificate was specified, and the default developer certificate could not be found or is out of date.
                 To generate a developer certificate run 'dotnet dev-certs https'. To trust the certificate (Windows and macOS only) run 'dotnet dev-certs https --trust'.
                 For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.

Log: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-53244-merge-70825d7803a14d418d/System.Runtime.Handles.Tests/console.0a5ec6f2.log?sv=2019-07-07&se=2021-06-15T09%3A21%3A11Z&sr=c&sp=rl&sig=e7vhUZhAD5az%2F02xFlxyPLPGrevU2QGJehJHI4SQh9I%3D

Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1156998&view=ms.vss-test-web.build-test-results-tab&runId=34940296&resultId=168965&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

@premun
Copy link
Member

premun commented May 26, 2021

I know about this fix: 57bdb95

@pavelsavara
Copy link
Member Author

pavelsavara commented May 26, 2021

Looking at Viktor's log I can see that the poweshell way of cert installation is there.
But it failed with execute.sh: powershell: not found which I have not noticed.

radical pushed a commit that referenced this pull request May 28, 2021
…efore xharness run via SDK or powershell (#53280)

Co-authored-by: Ankit Jain <radical@gmail.com>

Caused by #53180, #53225

- The original approach to install certificates didn't work because we don't have dotnet SDK, just runtime on Helix agents.
- dotnet dev-certs https needs user interaction with a dialog. Instead, using powershelgl to install certs
- Wasm.Build.Tests are being disabled here because of #53405

Fixes #53207
@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2021
@pavelsavara pavelsavara deleted the pr_helix_install_dev_cert branch July 29, 2021 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants