Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: LLVM fails for ios-arm #58112

Closed
rolfbjarne opened this issue Aug 25, 2021 · 4 comments · Fixed by #58192
Closed

iOS: LLVM fails for ios-arm #58112

rolfbjarne opened this issue Aug 25, 2021 · 4 comments · Fixed by #58192
Labels
area-Codegen-AOT-mono blocking-release
Milestone
6.0.0

Comments

@rolfbjarne
Copy link
Member

Description

Asking the AOT compiler to use LLVM fails with the ios-arm RuntimeIdentifier:

Tool /usr/local/share/dotnet/packs/Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm/6.0.0-rc.2.21424.7/Sdk/../tools/mono-aot-cross execution started with arguments: --aot=mtriple=armv7-ios,data-outfile=obj/Debug/net6.0-ios/ios-arm/nativelibraries/aot-output/armv7/Xamarin.iOS.aotdata,static,asmonly,direct-icalls,full,nodebug,dwarfdebug,llvm-path=/usr/local/share/dotnet/packs/Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm/6.0.0-rc.2.21424.7/Sdk/../tools,outfile=obj/Debug/net6.0-ios/ios-arm/nativelibraries/aot-output/armv7/Xamarin.iOS.dll.s,llvm-outfile=obj/Debug/net6.0-ios/ios-arm/nativelibraries/aot-output/armv7/Xamarin.iOS.dll.llvm.o --debug --llvm -O=gsharedvt /Users/rolf/work/maccore/dotnet-publish/SubmissionSamples/iOSCoolApp/dotnet/obj/Debug/net6.0-ios/ios-arm/linked/Xamarin.iOS.dll
[...]
llc: Unknown command line argument '-disable-fp-elim'.  Try: '/usr/local/share/dotnet/packs/Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm/6.0.0-rc.2.21424.7/Sdk/../tools/llc --help'
llc: Did you mean '--disable-lsr'?
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Codegen-AOT-mono untriaged New issue has not been triaged by the area owner labels Aug 25, 2021
@rolfbjarne
Copy link
Member Author

CC @steveisok @akoeplinger

@rolfbjarne rolfbjarne mentioned this issue Aug 25, 2021
Closed
61 tasks
@filipnavara
Copy link
Member

The option was renamed in newer LLVM, so this line needs to be changed:

runtime/src/mono/mono/mini/aot-compiler.c

Line 1152 in d40fbf4

g_string_append (acfg->llc_args, " -exception-model=dwarf -disable-fp-elim");

I think the new name of the option is -mframe-pointer=all.

@steveisok
Copy link
Member

/cc @SamMonoRT

@rolfbjarne rolfbjarne mentioned this issue Aug 25, 2021
Closed
rolfbjarne added a commit to rolfbjarne/SubmissionSamples that referenced this issue Aug 25, 2021
@rolfbjarne
[iOSCoolApp] Build only for ios-arm64, due to dotnet/runtime#58112.
df09867
rolfbjarne added a commit to xamarin/SubmissionSamples that referenced this issue Aug 26, 2021
@rolfbjarne
Port samples used for submission tests to .NET. (#38)
7f6bde1 
* [iTravel] Port to .NET 6.

* [FSharpiOSCoolApp] Port to .NET 6.

* [iOSCoolApp] Port to .NET 6.

* [iOSCoolApp] Build only for ios-arm64, due to dotnet/runtime#58112.

* [UICatalog] Port to .NET 6.

* [ODRsTVOS_Extension] Port to .NET 6.

* [SceneKitGame] Port to .NET 6.

* [MacCoolApp_DontLink] Port to .NET 6.

* [FSharpMacCoolApp] Port to .NET 6.

* Update .gitignore.
@SamMonoRT SamMonoRT removed the untriaged New issue has not been triaged by the area owner label Aug 26, 2021
@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Aug 26, 2021
@imhameed
Copy link
Contributor

Looks like the replacement flag is -frame-pointer=all:
dotnet/llvm-project@b7cef81
https://github.com/dotnet/llvm-project/blob/d3d2c8a945299ff90b998de4b3cdf863be0f043e/llvm/lib/CodeGen/CommandFlags.cpp#L176-L187

imhameed added a commit to imhameed/runtime that referenced this issue Aug 26, 2021
@imhameed
[mono] Replace -disable-fp-elim with -frame-pointer=all
3c91d1c 
`-disable-fp-elim` was removed in LLVM 8 in commit b7cef81fd36c85e52b115b9ed6d1fb92d63781d6.
Also see https://reviews.llvm.org/D56351.

The replacement option, `-frame-pointer`, is still present in LLVM 11.

Fixes dotnet#58112.
@imhameed imhameed mentioned this issue Aug 26, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 26, 2021
github-actions bot pushed a commit that referenced this issue Aug 26, 2021
@imhameed
[mono] Replace -disable-fp-elim with -frame-pointer=all
244a3f6 
`-disable-fp-elim` was removed in LLVM 8 in commit b7cef81fd36c85e52b115b9ed6d1fb92d63781d6.
Also see https://reviews.llvm.org/D56351.

The replacement option, `-frame-pointer`, is still present in LLVM 11.

Fixes #58112.
Anipik pushed a commit that referenced this issue Aug 27, 2021
@github-actions @imhameed
[mono] Replace -disable-fp-elim with -frame-pointer=all (#58195)
262b509 
`-disable-fp-elim` was removed in LLVM 8 in commit b7cef81fd36c85e52b115b9ed6d1fb92d63781d6.
Also see https://reviews.llvm.org/D56351.

The replacement option, `-frame-pointer`, is still present in LLVM 11.

Fixes #58112.

Co-authored-by: Imran Hameed <imhameed@microsoft.com>
imhameed added a commit that referenced this issue Aug 30, 2021
@imhameed
[mono] Replace -disable-fp-elim with -frame-pointer=all (#58192)
9703660 
`-disable-fp-elim` was removed in LLVM 8 in commit b7cef81fd36c85e52b115b9ed6d1fb92d63781d6.
Also see https://reviews.llvm.org/D56351.

The replacement option, `-frame-pointer`, is still present in LLVM 11.

Fixes #58112.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 30, 2021
filipnavara added a commit to filipnavara/SubmissionSamples that referenced this issue Sep 7, 2021
@filipnavara
Remove workaround for dotnet/runtime#58112
c03f4d8
rolfbjarne pushed a commit to xamarin/SubmissionSamples that referenced this issue Sep 8, 2021
@filipnavara
Remove workaround for dotnet/runtime#58112 (#40)
469d7f5
filipnavara added a commit to filipnavara/SubmissionSamples that referenced this issue Sep 8, 2021
@filipnavara
Revert "Remove workaround for dotnet/runtime#58112 (xamarin#40)"
befbc17 
This reverts commit 469d7f5.
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Codegen-AOT-mono blocking-release
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

[mono] Replace -disable-fp-elim with -frame-pointer=all imhameed/runtime
5 participants
@rolfbjarne @steveisok @filipnavara @SamMonoRT @imhameed