[release/6.0-rc1] [mono] Replace -disable-fp-elim with -frame-pointer=all #58195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
`-disable-fp-elim` was removed in LLVM 8 in commit b7cef81fd36c85e52b115b9ed6d1fb92d63781d6. Also see https://reviews.llvm.org/D56351. The replacement option, `-frame-pointer`, is still present in LLVM 11. Fixes #58112.
github-actions
bot
requested review from
imhameed,
lambdageek,
SamMonoRT and
vargaz
as code owners
Anipik
added
Servicing-approved
|
approved offline |
Anipik
approved these changes
Aug 27, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58192 to release/6.0-rc1
/cc @lambdageek @imhameed
Customer Impact
Mobile iOS on Arm(32) using LLVM 11 won't work. LLVM 11 introduced a new (replacement flag name), that's the only update.
Testing
Manual validation pending on arm32 mobile device. TODO - update this.
On CI, we focus testing on arm64(works fine). Testing is available, need to agree on running this on arm32 devices.
Risk
Close to zero risk. Straightforward name change for that flag. No backward compatibility issues.