Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mono jit/hardwareintrinsics/x86/x86base/pause tests failing #61693

Closed
runfoapp bot opened this issue Nov 16, 2021 · 5 comments · Fixed by #61707 or #73318
Closed

Mono jit/hardwareintrinsics/x86/x86base/pause tests failing #61693

runfoapp bot opened this issue Nov 16, 2021 · 5 comments · Fixed by #61707 or #73318
Assignees
@tannergooding
Labels
area-Codegen-JIT-mono
Milestone
7.0.0

Comments

@runfoapp
Copy link

runfoapp bot commented Nov 16, 2021 •
edited by agocke
Loading

These tests have been disabled for Mono, but will fail if enabled.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 16, 2021
@agocke agocke added area-Codegen-JIT-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' and removed untriaged New issue has not been triaged by the area owner labels Nov 16, 2021
@runfoapp runfoapp bot mentioned this issue Nov 16, 2021
Closed
@EgorBo
Copy link
Member

EgorBo commented Nov 16, 2021

@tannergooding I assume it's because these were not implemented in Mono, it should be fairly simple to implement via @llvm.x86.sse2.pause()

@tannergooding tannergooding mentioned this issue Nov 17, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 17, 2021
@agocke agocke mentioned this issue Nov 17, 2021
Merged
@echesakov echesakov mentioned this issue Nov 18, 2021
Closed
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 22, 2021
@jkotas jkotas mentioned this issue Dec 2, 2021
Open
@agocke agocke reopened this Dec 2, 2021
@agocke
Copy link
Member

agocke commented Dec 2, 2021

Re-opening as the PR didn't fix the problem. These tests are still disabled on Mono

@agocke agocke removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Dec 2, 2021
@EgorBo EgorBo mentioned this issue Dec 6, 2021
Closed
@fanyang-mono
Copy link
Member

This test should be enabled when LLVM is enabled.

@fanyang-mono fanyang-mono added this to the 7.0.0 milestone Jul 21, 2022
@SamMonoRT
Copy link
Member

This test should be enabled when LLVM is enabled.

are these passing on llvm lane or is there more work needed ? If passing, can we exclude only for relevant lanes via the issues.target file ?

@fanyang-mono fanyang-mono mentioned this issue Aug 3, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 3, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tannergooding tannergooding

Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
7.0.0
5 participants
@agocke @EgorBo @tannergooding @SamMonoRT @fanyang-mono