[Mono] Enable X86Base.Pause test #73318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
force-pushed
the
enable_pause_test
branch
from
b9a2e52
to
7d97d63
Compare
SamMonoRT
reviewed
Aug 3, 2022
src/tests/issues.targets
Outdated
| @@ -2720,6 +2716,12 @@ | |||
| <!-- End interpreter issues --> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(RuntimeFlavor)' == 'mono' and '$(RuntimeVariant)' != 'llvmaot' and '$(RuntimeVariant)' != 'llvmfullaot' "> | |||
| <ExcludeList Include = "$(XUnitTestBinBase)/JIT/HardwareIntrinsics/X86/X86Base/Pause*/**"> | |||
| <Issue>https://github.com/dotnet/runtime/pull/61707#issuecomment-973122341</Issue> | |||
There was a problem hiding this comment.
is there no actual issue for tracking this ?
There was a problem hiding this comment.
I can create one. Given the trend that we are focusing on AOT with LLVM. I doubt that we will ever have any bandwidth to support this for non-LLVM scenarios.
vargaz
approved these changes
Aug 4, 2022
|
The Pause test is failing on llvm aot lanes is because there is an issue with exception handling when LLVM is enabled. I am looking into it. |
This was referenced Aug 5, 2022
fanyang-mono
force-pushed
the
enable_pause_test
branch
from
64b9c14
to
8c98bdc
Compare
|
Failures on CI is not related to this PR. |
fanyang-mono
changed the title
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61693
SIMD intrinsics support for X86Base.Pause for Mono was originally added by Tanner via #61707. But soon it was reverted by #62157, since it caused test failures on CI. The change Tanner made originally was a good change. I am adding it back in this PR and make sure to exclude the test properly for Mono CI lanes. The Pause test should only run on Mono when LLVM is enabled.