-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests][tvOS] Some System.IO tests are failing #67853
Comments
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsOS: tvOS It appears that some System.IO tests on tvOS have been silently failing for at least a month. The #67746 bugfix removes a crash that prevented xharness from reporting the test failures properly (e.g. rolling build from 4/10 with this System.IO.Tests output). The following tests are failing:
|
Tagging subscribers to 'os-tvos': @steveisok, @akoeplinger Issue DetailsOS: tvOS It appears that some System.IO tests on tvOS have been silently failing for at least a month. The #67746 bugfix removes a crash that prevented xharness from reporting the test failures properly (e.g. rolling build from 4/10 with this System.IO.Tests output). The following tests are failing:
|
There is some overlap with #51371 |
A lot of the failures are asserting at runtime/src/libraries/Common/tests/TestUtilities/System/IO/FileCleanupTestBase.cs Line 159 in 51d11eb
#63877 was intended to fix these issues and it appears they did on iOSSimulator, but we got a false positive from CI when it came to devices. |
A newline was incorrectly added to the script that executes xharness, causing the script to return a 0 exit code even if there was a crash. This caused CI to report a pass no matter what. System.IO.Tests was the only suite found where this had an impact. Contributes to dotnet#67853
tvOS has a MAX_PATH of 104 characters on domain sockets, and a 90 character value for GetTempPath. That gives us only 14 characters to play with, and temp filenames are 12 characters long. We cannot afford the `CoreFxPipe_` prefix on tvOS, with our tiny character path budget. Check whether this fixes some or all of dotnet#67853 and dotnet#51390 too.
Reopening. This issue is a collection of entirely unrelated issues, and likely not even tvOS specific. We have dozens of ActiveIssue for this bug number, will close when those are handled. |
This is actually a mix of three distinct bugs:
|
Okay then. Detailed failures info: Unexpected behaviour with
throws:
Assumes writable app directory:
throws:
Trying to use Windows UNC from app directory:
throws:
|
Gotta use remote executor to use SetCurrentDirectory to fix the UNC & drive letter tests, apparently. |
non-Windows out of the app's working directory, which is readonly on some platforms. Closes: dotnet#67853
* Use SetCurrentDirectory on tests which use an unrooted path on non-Windows out of the app's working directory, which is readonly on some platforms. Closes: #67853 * Just blank out mkfifo tests
OS: tvOS
Architecture: arm64
Configuration: release
Runtime: mono
It appears that some System.IO tests on tvOS have been silently failing for at least a month. The #67746 bugfix removes a crash that prevented xharness from reporting the test failures properly (e.g. rolling build from 4/10 with this System.IO.Tests output).
The following tests are failing:
DevicesPipesAndSockets.NamedPipe_ReadWrite
DevicesPipesAndSockets.NamedPipe_ReadWrite_Async
NamedPipeFileStreamConnectedConformanceTests.Dispose_ClosesStream
NamedPipeFileStreamConnectedConformanceTests.Read_Eof_Returns0
NamedPipeFileStreamConnectedConformanceTests.Disposed_ThrowsObjectDisposedException
NamedPipeFileStreamConnectedConformanceTests.ZeroByteWrite_OtherDataReceivedSuccessfully
NamedPipeFileStreamConnectedConformanceTests.Read_DataStoredAtDesiredOffset
NamedPipeFileStreamConnectedConformanceTests.ReadAsync_ContinuesOnCurrentTaskSchedulerIfDesired
NamedPipeFileStreamConnectedConformanceTests.ReadAsync_CancelPendingTask_ThrowsCancellationException
NamedPipeFileStreamConnectedConformanceTests.Write_DataReadFromDesiredOffset
NamedPipeFileStreamConnectedConformanceTests.ReadAsync_ContinuesOnCurrentSynchronizationContextIfDesired
NamedPipeFileStreamConnectedConformanceTests.ArgumentValidation_ThrowsExpectedException
NamedPipeFileStreamConnectedConformanceTests.ReadTimeout_Expires_Throws
NamedPipeFileStreamConnectedConformanceTests.Flush_ValidOnWriteableStreamWithNoData_Success
NamedPipeFileStreamConnectedConformanceTests.ZeroByteRead_BlocksUntilDataAvailableOrNops
NamedPipeFileStreamConnectedConformanceTests.ReadAsync_CancelPendingValueTask_ThrowsCancellationException
NamedPipeFileStreamConnectedConformanceTests.ReadWriteAsync_PrecanceledOperations_ThrowsCancellationException
NamedPipeFileStreamConnectedConformanceTests.Timeout_Roundtrips
NamedPipeFileStreamConnectedConformanceTests.ReadWrite_CustomMemoryManager_Success
NamedPipeFileStreamConnectedConformanceTests.Flush_ValidOnReadableStream_Success
NamedPipeFileStreamConnectedConformanceTests.ReadWriteByte_Success
NamedPipeFileStreamConnectedConformanceTests.ReadWrite_MessagesSmallerThanReadBuffer_Success
NamedPipeFileStreamConnectedConformanceTests.CopyToAsync_AllDataCopied
NamedPipeFileStreamConnectedConformanceTests.ReadWrite_Success
Directory_ExistsAsFile.FalseForNonRegularFile
DirectoryInfo_EnumFSI_str_str.SearchPatternCaseSensitive
FileInfo_Exists.TrueForNonRegularFile
Directory_Delete_str_bool.ExtendedDirectoryWithSubdirectories
Directory_Delete_str_bool.LongPathExtendedDirectory
File_GetSetAttributesCommon.SettingInvalidAttributes_UnixExceptOSXAndFreeBSD(attributes: Hidden)
Directory_CreateDirectory.DriveLetter_Unix
Directory_EnumFSE_str_str_so.SearchPatternCaseSensitive
File_ReadWriteAllBytes.ReadAllBytes_NonSeekableFileStream_InUnix
FileInfo_GetSetAttributesCommon.SettingInvalidAttributes_UnixExceptOSXAndFreeBSD(attributes: Hidden)
PathFile_Exists.TrueForNonRegularFile
DirectoryInfo_Delete_bool.ExtendedDirectoryWithSubdirectories
DirectoryInfo_Delete_bool.LongPathExtendedDirectory
File_ReadWriteAllBytesAsync.ReadAllBytesAsync_NonSeekableFileStream_InUnix
File_ExistsAsDirectory.FalseForNonRegularFile
Directory_GetLogicalDrives.GetsValidDriveStrings_Unix
DirectoryInfo_Create.DriveLetter_Unix
DirectoryInfo_Exists.FalseForNonRegularFile
DirectoryInfo_Delete.ExtendedDirectoryWithSubdirectories
DirectoryInfo_Delete.LongPathExtendedDirectory
Directory_Delete_str.ExtendedDirectoryWithSubdirectories
Directory_Delete_str.LongPathExtendedDirectory
The text was updated successfully, but these errors were encountered: