Skip to content

Commit

Permalink
[iOS] Remove unnecessary newline from CI script
Browse files Browse the repository at this point in the history
A newline was incorrectly added to the script that executes xharness, causing the script to return a 0 exit code even if there was a crash.  This caused CI to report a pass no matter what.  System.IO.Tests was the only suite found where this had an impact.

Contributes to dotnet#67853
  • Loading branch information
Steve Pfister committed Jul 20, 2022
1 parent 73c2ce3 commit bc27e00
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions eng/testing/tests.ioslike.targets
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
<_AfterBuildCommands>
mv $XHARNESS_OUT/AOTBuild.binlog &quot;$HELIX_WORKITEM_UPLOAD_ROOT&quot;
sign &quot;$app&quot;
xharness apple test --app &quot;$app&quot; --output-directory &quot;$output_directory&quot; --target &quot;$target&quot; --timeout &quot;$timeout&quot; --xcode &quot;$xcode_path&quot; -v --launch-timeout &quot;$launch_timeout&quot; $(_ResetSimulatorSwitch) $(_SignalAppEndSwitch) --
</_AfterBuildCommands>
xharness apple test --app &quot;$app&quot; --output-directory &quot;$output_directory&quot; --target &quot;$target&quot; --timeout &quot;$timeout&quot; --xcode &quot;$xcode_path&quot; -v --launch-timeout &quot;$launch_timeout&quot; $(_ResetSimulatorSwitch) $(_SignalAppEndSwitch) -- </_AfterBuildCommands>

<RunScriptCommand>$(_AOTBuildCommand) $(_AfterBuildCommands)</RunScriptCommand>
</PropertyGroup>
Expand Down

0 comments on commit bc27e00

Please sign in to comment.