-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure JIT\\Intrinsics\\TypeIntrinsics_r\\TypeIntrinsics_r.cmd #69976
Comments
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsRun: runtime-coreclr r2r-extra 20220528.1 Failed test:
Error message:
More failures
|
Failed again in: runtime-coreclr gcstress-extra 20220605.1 Failed test:
Error message:
|
Lots of failures in "plain" Linux/arm32 GCStress=0xC: |
Failed again in: runtime-coreclr gcstress-extra 20220625.1 Failed test:
Error message:
|
Failed again in: runtime-coreclr r2r-extra 20220703.1 Failed test:
Error message:
|
Failed again in: runtime-coreclr gcstress0x3-gcstress0xc 20220717.1 Failed test:
Erroor message:
|
We are still hitting some gcstress issues on linux-arm32, but I don't see any on other platforms. |
This is the same problem as fixed by #70053 for arm64, introduced by #69202. @kunalspathak I'm a little confused about the fix there, why not align this logic to be the same as x64? It looks like the net effect of #69202 + #70053 was to move the GC ref layout check from lowering to codegen for arm64, while on x64 it just happens in lowering. Is there any particular reason to not just do the same thing as on x64? |
The check in codegen runs only for arm64 but this check needs to happen for arm32 as well. This moves the GC ref layout check back to lowering and aligns it with xarch as well. Fix dotnet#69976
Ah, I think I understand, having the check in codegen is useful because sometimes we may not need to form new byrefs in which case it is unnecessary to disable GC. But for layouts with GC ptrs we do always need to disable it, so we can move that specific part of the check back to happen early instead. |
The check in codegen runs only for arm64 but this check needs to happen for arm32 as well. This moves the GC ref layout check back to lowering and aligns it with xarch as well. Fix #69976
Run: runtime-coreclr r2r-extra 20220528.1
Failed test:
Error message:
More failures
The text was updated successfully, but these errors were encountered: