Ensure we do not corrupt RAX for CFG dispatcher on x64 #70016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jump stubs used on x64 will clutter rax which is used for the target address in the CFG dispatcher. When this happened for the CFG dispatcher it would result in an infinite loop. The same problem is already handled for some other helpers as pointed out by @jkotas, so simply add the CFG dispatcher to that set.
ghost
assigned 
|
/azp run jit-cfg |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jump stubs used on x64 will clutter rax which is used for the target
address in the CFG dispatcher. When this happened for the CFG dispatcher
it would result in an infinite loop.
The same problem is already handled for some other helpers as pointed
out by @jkotas, so simply add the CFG dispatcher to that set.