Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name of WebAssembly tools in VS setup doesn't deliniate what a versionless description is #93314

Closed
timheuer opened this issue Oct 2, 2023 · 5 comments · Fixed by #102446
Closed

Name of WebAssembly tools in VS setup doesn't deliniate what a versionless description is #93314

timheuer opened this issue Oct 2, 2023 · 5 comments · Fixed by #102446
Assignees
@maraf
Labels
arch-wasm WebAssembly architecture area-Workloads Workloads like wasm-tools in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@timheuer
Copy link
Member

timheuer commented Oct 2, 2023

Description

image
In this view, it is not clear what the versionless is. Feedback from customers and internal has been confusion. Just put the version number always

Reproduction Steps

Run VS Setup and look for WebAssembly component

Expected behavior

See specific versions

Actual behavior

Two are versioned, one is not

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 2, 2023
@timheuer
Copy link
Member Author

timheuer commented Oct 2, 2023

@lewing

@vcsjones vcsjones added arch-wasm WebAssembly architecture area-Setup labels Oct 2, 2023
@ghost
Copy link

ghost commented Oct 2, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

image
In this view, it is not clear what the versionless is. Feedback from customers and internal has been confusion. Just put the version number always

Reproduction Steps

Run VS Setup and look for WebAssembly component

Expected behavior

See specific versions

Actual behavior

Two are versioned, one is not

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author: timheuer
Assignees: -
Labels:

arch-wasm, area-Setup, untriaged
Milestone: -

@NikolaMilosavljevic NikolaMilosavljevic transferred this issue from dotnet/runtime Oct 3, 2023
@marcpopMSFT marcpopMSFT transferred this issue from dotnet/installer Oct 10, 2023
@marcpopMSFT
Copy link
Member

The string is actually generated from the workload manifest description of the workload here: https://github.com/dotnet/runtime/blob/main/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WorkloadManifest.json.in#L8. It probably makes sense to put the version even in the current manifest to make it easier to differentiate in VS.

@marcpopMSFT
Copy link
Member

@steveisok

@radical radical added area-Workloads Workloads like wasm-tools and removed area-Setup labels Oct 11, 2023
radical added a commit to radical/runtime that referenced this issue Oct 11, 2023
@radical
[wasm] Update workload description to include target framework
435bbc6 
Issue: dotnet#93314
@radical radical mentioned this issue Oct 11, 2023
Merged
@radical
Copy link
Member

radical commented Oct 11, 2023

The string in the screenshot is different from the manifest json though:
NET 7.0 WebAssembly build tools vs .NET WebAssembly build tools for net7.0(https://github.com/dotnet/runtime/blob/main/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.net7.Manifest/WorkloadManifest.json.in#L8).
Is a corresponding VS specific change needed somewhere too?

carlossanlop pushed a commit that referenced this issue Oct 13, 2023
@radical
[release/8.0][wasm] Update workload description to include target fra…
9e8d548 
…mework (#93359)

* [wasm] Update workload description to include target framework

Issue: #93314

* Update description for wasm-experimental, and wasi-experimental also
@lewing lewing added this to the 9.0.0 milestone Apr 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Apr 1, 2024
@maraf maraf mentioned this issue May 17, 2024
Merged
@ilonatommy ilonatommy mentioned this issue May 20, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label May 20, 2024
@ilonatommy ilonatommy mentioned this issue May 20, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Workloads Workloads like wasm-tools in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
9.0.0
6 participants
@radical @timheuer @lewing @vcsjones @maraf @marcpopMSFT