You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disambiguates the workload description for the 8.0 workload, so instead of .NET WebAssembly build tools the user will see .NET WebAssembly build tools for net8.0. And that's the same for 6.0, and 7.0 wasm workloads.
radical
changed the title
[wasm] Update workload description to include target framework
[release/8.0][wasm] Update workload description to include target framework
Oct 11, 2023
@marcpopMSFT do I need to change the corresponding localized descriptions?
@radical what's your process for localizing these? I think yes but I haven't actually tested out a localized VS install (on the CLI, we will display the localized description in dotnet workload search)
@marcpopMSFT do I need to change the corresponding localized descriptions?
@radical what's your process for localizing these? I think yes but I haven't actually tested out a localized VS install (on the CLI, we will display the localized description in dotnet workload search)
@marcpopMSFT do I need to change the corresponding localized descriptions?
@radical what's your process for localizing these? I think yes but I haven't actually tested out a localized VS install (on the CLI, we will display the localized description in dotnet workload search)
IIUC, we don't really have a process for that, or seem to update them really. I guess, it is only being done on VS side then.
I doubt the loc is done on the VS side as it probably uses the value from here. @joeloff do you know for sure how loc versions of VS work for workload descriptions/names?
I doubt the loc is done on the VS side as it probably uses the value from here. @joeloff do you know for sure how loc versions of VS work for workload descriptions/names?
There is no localization on the VS side because the component is built in the runtime repo and the tooling used to generate the setup authoring is unaware of the localization strings in the workload manifest package. It is a known issue. Fixing the strings in runtime will update the localization experience for CLI based installations only
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
radical
changed the title
ghost
locked as resolved and limited conversation to collaborators
Issue: #93314
Customer Impact
Disambiguates the workload description for the 8.0 workload, so instead of
.NET WebAssembly build toolsthe user will see.NET WebAssembly build tools for net8.0. And that's the same for 6.0, and 7.0 wasm workloads.Testing
Manual.
Risk
None. Just a change in description.