Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V][LoongArch64] HijackFrame::UpdateRegDisplay update A0 #106018

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[RISC-V][LoongArch64] HijackFrame::UpdateRegDisplay update A0 #106018

merged 1 commit into from
Aug 7, 2024

Conversation

t-mustafin
Copy link
Contributor

Update A0 as for arm64, arm and amd64.

cc @dotnet/samsung part of #84834.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 6, 2024
@t-mustafin
Copy link
Contributor Author

t-mustafin commented Aug 6, 2024 •
edited
Loading

@shushanhf loongarch64 may need same change.

UPD: included LoongArch64 change in this PR.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@t-mustafin t-mustafin changed the title [RISC-V] HijackFrame::UpdateRegDisplay update A0 [RISC-V][LoongArch64] HijackFrame::UpdateRegDisplay update A0 Aug 6, 2024
This was referenced Aug 6, 2024
Open
Open
@shushanhf
Copy link
Contributor

@shushanhf loongarch64 may need same change.

UPD: included LoongArch64 change in this PR.

Thanks very much!

@jkotas jkotas merged commit 5598791 into dotnet:main Aug 7, 2024
88 of 90 checks passed
@clamp03 clamp03 added arch-loongarch64 arch-riscv Related to the RISC-V architecture labels Aug 7, 2024
gbalykov
gbalykov reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@gbalykov gbalykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tomeksowi
tomeksowi reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@tomeksowi tomeksowi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-mustafin t-mustafin deleted the riscv_a0_hijack branch August 7, 2024 09:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gbalykov gbalykov gbalykov left review comments

@tomeksowi tomeksowi tomeksowi left review comments

@Bajtazar Bajtazar Bajtazar approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@t-mustafin t-mustafin

Labels
arch-loongarch64 arch-riscv Related to the RISC-V architecture area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@t-mustafin @shushanhf @tomeksowi @jkotas @gbalykov @Bajtazar @clamp03