CoreCLR RISC-V architecture port

[gbalykov]

Current status

Our initial goal was to get to 100% pass rate for CodeGen BringUp tests in Debug mode. We've achieved this both on qemu and on StarFive VisionFive2 board.

For this, all changes are currenlty in PRs created by my colleagues @clamp03 @t-mustafin:

• already merged ([RISC-V] coreclr-jit directory #82379, [RISC-V] others except coreclr #82382, [RISC-V][JIT] Fix assert on passing double in struct #84584, [RISC-V] Fix build fail #84608, [RISC-V] coreclr-pal and coreclr-debug directories #82380)
• not yet merged at the moment of writing ([RISC-V][JIT] JIT/CodeGenBringUpTest #84748, [RISC-V] coreclr-vm and other directories in coreclr #82381, [RISC-V][GC] Use 128gb for regions_range on RISCV64 #84797).

So, when all of the above are merged, CodeGen BringUp tests launched on main branch should pass both on VisionFive2 and qemu (for StarFive VisionFive2 board GC_REGIONS also need to be disabled currently, we are already investigating this).

Current test results for full JIT directory on VisionFive2 in Debug with DOTNET_GCgen0size=99999999:

# Tests Discovered : 4737
# Passed           : 4304
# Failed           : 413
# Skipped          : 20

Current test results for all tests on VisionFive2 in Debug with DOTNET_GCgen0size=99999999:

# Tests Discovered : 6565
# Passed           : 5663
# Failed           : 861
# Skipped          : 41

Further plans

Our further plans for near future:

• focus on full JIT tests directory to make tests pass in Release/Debug/Checked mode and with/without DOTNET_GCgen0size=99999999
• fix TODOs, which are not related to jit optimizations
• add build CI in dotnet/runtime repo for RISC-V
• add CI in dotnet/runtime repo for RISC-V with some tests run on qemu
• enable JitDisasm and JitDump
• fix or disable GC_REGIONS on VisionFive2
• focus on more tests dirs with Release/Debug/Checked build of runtime after all of the above
• focus on libraries (corefx) tests to make innerloop/outerloop tests pass
• jitstress, jitstressregs, gcstress testing

What's currently not in our plans for near future:

• full jit optimizations with all optimization passes (i.e. disabled MinOpt, tiered compilation, etc.)
• optimizations of codegen itself
• crossgen2 support
• SIMD and intrinsics support
• GC (not sure about this yet, need to check current status without DOTNET_GCgen0size=99999999 and with/without FEATURE_CONSERVATIVE_GC)
• EH, stackwalking, and interop portions (also not sure, need to check current status)
• stubs optimizations, GC optimizations, etc.

Process

In overall, we basically follow https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/jit/porting-ryujit.md and https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/botr/guide-for-porting.md. We categorize failing tests by error type. Soon we'll open separate issue on what's currently being worked on.

Related issues

#36748, #75749

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Current status

Our initial goal was to get to 100% pass rate for CodeGen BringUp tests in Debug mode. We've achieved this both on qemu and on StarFive VisionFive2 board.

For this, all changes are currenlty in PRs created by my colleagues @clamp03 @t-mustafin:

• already merged ([RISC-V] coreclr-jit directory #82379, [RISC-V] others except coreclr #82382, [RISC-V][JIT] Fix assert on passing double in struct #84584, [RISC-V] Fix build fail #84608, [RISC-V] coreclr-pal and coreclr-debug directories #82380)
• not yet merged at the moment of writing ([RISC-V][JIT] JIT/CodeGenBringUpTest #84748, [RISC-V] coreclr-vm and other directories in coreclr #82381, [RISC-V][GC] Use 128gb for regions_range on RISCV64 #84797).

So, when all of the above are merged, CodeGen BringUp tests launched on main branch should pass both on VisionFive2 and qemu (for StarFive VisionFive2 board GC_REGIONS also need to be disabled currently, we are already investigating this).

Current test results for full JIT directory on VisionFive2 in Debug with DOTNET_GCgen0size=99999999:

# Tests Discovered : 4737
# Passed           : 4304
# Failed           : 413
# Skipped          : 20

Current test results for all tests on VisionFive2 in Debug with DOTNET_GCgen0size=99999999:

# Tests Discovered : 6565
# Passed           : 5663
# Failed           : 861
# Skipped          : 41

Further plans

Our further plans for near future:

• focus on full JIT tests directory to make tests pass in Debug mode and with DOTNET_GCgen0size=99999999
• fix TODOs, which are not related to jit optimizations
• add CI in dotnet/runtime repo for RISC-V with some tests run on qemu
• enable JitDisasm and JitDump
• fix or disable GC_REGIONS on VisionFive2
• focus on more tests dirs with Debug build of runtime after all of the above

What's currently not in our plans for near future:

• full jit optimizations with all optimization passes (i.e. disabled MinOpt, tiered compilation, etc.)
• optimizations of codegen itself
• crossgen2 support
• SIMD and intrinsics support
• jitstress, jitstressregs, gcstress testing
• GC (not sure about this yet, need to check current status without DOTNET_GCgen0size=99999999 and with/without FEATURE_CONSERVATIVE_GC)
• EH, stackwalking, and interop portions (also not sure, need to check current status)
• running libraries (corefx) tests
• stubs optimizations, GC optimizations, etc.

Process

In overall, we basically follow https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/jit/porting-ryujit.md and https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/botr/guide-for-porting.md. We categorize failing tests by error type. Soon we'll open separate issue on what's currently being worked on.

Related issues

#36748, #75749

Author:	gbalykov
Assignees:	-
Labels:	area-CodeGen-coreclr, untriaged
Milestone:	-

[gbalykov]

CC @wscho77 @HJLeee @JongHeonChoi @t-mustafin @clamp03 @alpencolt @jakobbotsch

[ghost]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Current status

Our initial goal was to get to 100% pass rate for CodeGen BringUp tests in Debug mode. We've achieved this both on qemu and on StarFive VisionFive2 board.

For this, all changes are currenlty in PRs created by my colleagues @clamp03 @t-mustafin:

• already merged ([RISC-V] coreclr-jit directory #82379, [RISC-V] others except coreclr #82382, [RISC-V][JIT] Fix assert on passing double in struct #84584, [RISC-V] Fix build fail #84608, [RISC-V] coreclr-pal and coreclr-debug directories #82380)
• not yet merged at the moment of writing ([RISC-V][JIT] JIT/CodeGenBringUpTest #84748, [RISC-V] coreclr-vm and other directories in coreclr #82381, [RISC-V][GC] Use 128gb for regions_range on RISCV64 #84797).

So, when all of the above are merged, CodeGen BringUp tests launched on main branch should pass both on VisionFive2 and qemu (for StarFive VisionFive2 board GC_REGIONS also need to be disabled currently, we are already investigating this).

Current test results for full JIT directory on VisionFive2 in Debug with DOTNET_GCgen0size=99999999:

# Tests Discovered : 4737
# Passed           : 4304
# Failed           : 413
# Skipped          : 20

Current test results for all tests on VisionFive2 in Debug with DOTNET_GCgen0size=99999999:

# Tests Discovered : 6565
# Passed           : 5663
# Failed           : 861
# Skipped          : 41

Further plans

Our further plans for near future:

• focus on full JIT tests directory to make tests pass in Debug mode and with DOTNET_GCgen0size=99999999
• fix TODOs, which are not related to jit optimizations
• add CI in dotnet/runtime repo for RISC-V with some tests run on qemu
• enable JitDisasm and JitDump
• fix or disable GC_REGIONS on VisionFive2
• focus on more tests dirs with Debug build of runtime after all of the above

What's currently not in our plans for near future:

• full jit optimizations with all optimization passes (i.e. disabled MinOpt, tiered compilation, etc.)
• optimizations of codegen itself
• crossgen2 support
• SIMD and intrinsics support
• jitstress, jitstressregs, gcstress testing
• GC (not sure about this yet, need to check current status without DOTNET_GCgen0size=99999999 and with/without FEATURE_CONSERVATIVE_GC)
• EH, stackwalking, and interop portions (also not sure, need to check current status)
• running libraries (corefx) tests
• stubs optimizations, GC optimizations, etc.

Process

In overall, we basically follow https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/jit/porting-ryujit.md and https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/botr/guide-for-porting.md. We categorize failing tests by error type. Soon we'll open separate issue on what's currently being worked on.

Related issues

#36748, #75749

Author:	gbalykov
Assignees:	-
Labels:	area-Meta, untriaged
Milestone:	-

[JakeSays]

At first I was excited to see this RISCV work, but the list of 'not planned' stuff is significant.

[shushanhf]

@gbalykov @t-mustafin @clamp03
You should be careful before pushing PRs to avoid destroying the LoongArch64's code, liking #84584 #82381

[alpencolt]

JitDisasm and JitDump work on RISC-V. Could be excluded from list.

[JulieLeeMSFT]

cc @mangod9

[shushanhf]

@clamp03 @BruceForstall @jakobbotsch

As #82294, the RISCV64 is based on LoongArch64, the RISCV64 is so similarity with LoongArch64.

When I push LA64's PR, if also fix the RISCV64 with LoongArch64, while the LA64's patch I had tested on LA64's PC but I don't have the RISCV64 and can't test the RISCV64.

What do you mean?

[BruceForstall]

@shushanhf I don't quite understand what you are asking.

I think you are saying: you can change LA64 and test LA64, but cannot build/test RISC-V. Is the question: how to do this? Or, what kind of testing is expected?

Currently, there is no building/testing of LA64 or RISC-V in the CI system. I don't expect that to change. Perhaps it would be a good idea to make it easy to build and possibly even do minimal testing ("smoke testing") of both platforms. I don't expect Microsoft will ever want to make that a pre-checkin requirement for changes to this repository -- the RISC-V and LA64 teams will still be responsible for actively monitoring for changes, and reacting to required changes in the VM and JIT. But if building/testing is easy, perhaps it will give better advanced notice to all teams of potential issues or work.

[jkotas]

We are open to sponsor CI build-only legs for community supported targets to prevent trivial build breaks from getting in. Tizen and FreeBSD ports are on this plan today. If you are interested, create build environment with Linux x64 hosted cross-build environment in https://github.com/dotnet/dotnet-buildtools-prereqs-docker/ repo first.