Add linux-riscv64 nativeaot runtime build #110688

am11 · 2024-12-13T11:46:03Z

This change enables NativeAOT build support on Linux-RISCV64, leveraging the LA64 port https://github.com/dotnet/runtime/pulls?q=sort%3Aupdated-desc+is%3Apr+label%3Aarch-loongarch64+label%3Aarea-NativeAOT-coreclr+is%3Aclosed. While the build setup is functional, it has not yet been tested. This submission primarily aims to share the code changes required to achieve a successful build. Comprehensive testing and validation are contingent on resolving community-supported platform build processes, which are currently blocked on #105004.

Huge props to @sunlijun-610 for helping out with this. 🎉

Contributes to #106223, #84834

dotnet-policy-service · 2024-12-13T11:47:03Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

clamp03 · 2024-12-16T01:48:08Z

@tomeksowi @sirntar Please review and test this PR in SRPOL? Thank you.

am11 · 2024-12-16T03:37:58Z

This is bulk of change which just builds. _NativeAotSupportedArch condition:

runtime/eng/Subsets.props

Line 125 in 3aa1ec5

    
           <_NativeAotSupportedArch Condition="'$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'arm64' or '$(TargetArchitecture)' == 'arm' or '$(TargetArchitecture)' == 'loongarch64' or ('$(TargetOS)' == 'windows' and '$(TargetArchitecture)' == 'x86')">true</_NativeAotSupportedArch>

is not changed because that breaks the build in similar way as #108973 (requires LKG apphost). I think after this bulk of change is merged (need to make sure it doesn't break anyone's workflow), we can make smaller fixes once we figure out a way to test nativeaot runtime on community platforms.

risc-vv · 2024-12-16T08:47:05Z

c01dc7b is being scheduled for building and testing

GIT: c01dc7bbae7789bbf992d827ce9fe662aeb17c79
REPO: dotnet/runtime
BRANCH: main

Release-build FAILED

buildinfo.json

Cloning into '/go-agent/pipelines/Release-build/runtime'...
Updating files:  14% (8701/59681)
Updating files:  15% (8953/59681)
Updating files:  16% (9549/59681)
Updating files:  17% (10146/59681)
Updating files:  18% (10743/59681)
Updating files:  19% (11340/59681)
Updating files:  20% (11937/59681)
Updating files:  21% (12534/59681)
Updating files:  22% (13130/59681)
Updating files:  23% (13727/59681)
Updating files:  24% (14324/59681)
Updating files:  25% (14921/59681)
Updating files:  26% (15518/59681)
Updating files:  27% (16114/59681)
Updating files:  28% (16711/59681)
Updating files:  29% (17308/59681)
Updating files:  30% (17905/59681)
Updating files:  31% (18502/59681)
Updating files:  32% (19098/59681)
Updating files:  32% (19410/59681)
Updating files:  33% (19695/59681)
Updating files:  34% (20292/59681)
Updating files:  35% (20889/59681)
Updating files:  36% (21486/59681)
Updating files:  37% (22082/59681)
Updating files:  38% (22679/59681)
Updating files:  39% (23276/59681)
Updating files:  40% (23873/59681)
Updating files:  41% (24470/59681)
Updating files:  42% (25067/59681)
Updating files:  43% (25663/59681)
Updating files:  44% (26260/59681)
Updating files:  45% (26857/59681)
Updating files:  46% (27454/59681)
Updating files:  47% (28051/59681)
Updating files:  48% (28647/59681)
Updating files:  49% (29244/59681)
Updating files:  50% (29841/59681)
Updating files:  51% (30438/59681)
Updating files:  51% (30671/59681)
Updating files:  52% (31035/59681)
Updating files:  53% (31631/59681)
Updating files:  54% (32228/59681)
Updating files:  55% (32825/59681)
Updating files:  56% (33422/59681)
Updating files:  57% (34019/59681)
Updating files:  58% (34615/59681)
Updating files:  59% (35212/59681)
Updating files:  60% (35809/59681)
Updating files:  61% (36406/59681)
Updating files:  62% (37003/59681)
Updating files:  63% (37600/59681)
Updating files:  64% (38196/59681)
Updating files:  65% (38793/59681)
Updating files:  66% (39390/59681)
Updating files:  67% (39987/59681)
Updating files:  68% (40584/59681)
Updating files:  69% (41180/59681)
Updating files:  70% (41777/59681)
Updating files:  71% (42374/59681)
Updating files:  72% (42971/59681)
Updating files:  73% (43568/59681)
Updating files:  74% (44164/59681)
Updating files:  75% (44761/59681)
Updating files:  76% (45358/59681)
Updating files:  77% (45955/59681)
Updating files:  77% (46219/59681)
Updating files:  78% (46552/59681)
Updating files:  79% (47148/59681)
Updating files:  80% (47745/59681)
Updating files:  81% (48342/59681)
Updating files:  82% (48939/59681)
Updating files:  83% (49536/59681)
Updating files:  84% (50133/59681)
Updating files:  85% (50729/59681)
Updating files:  86% (51326/59681)
Updating files:  87% (51923/59681)
Updating files:  88% (52520/59681)
Updating files:  89% (53117/59681)
Updating files:  90% (53713/59681)
Updating files:  91% (54310/59681)
Updating files:  91% (54552/59681)
Updating files:  92% (54907/59681)
Updating files:  93% (55504/59681)
Updating files:  94% (56101/59681)
Updating files:  95% (56697/59681)
Updating files:  96% (57294/59681)
Updating files:  97% (57891/59681)
Updating files:  98% (58488/59681)
Updating files:  99% (59085/59681)
Updating files: 100% (59681/59681)
Updating files: 100% (59681/59681), done.

risc-vv · 2024-12-16T09:49:24Z

RISC-V Release-CLR-QEMU: 9440 / 9461 (99.78%)

=======================
      passed: 9440
      failed: 4
     skipped: 107
      killed: 17
------------------------
  TOTAL libs: 9568
 TOTAL tests: 9568
   REAL time: 57min 21s 277ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 603280 / 643384 (93.77%)

=======================
      passed: 603280
      failed: 321
     skipped: 1443
      killed: 39783
------------------------
  TOTAL libs: 256
 TOTAL tests: 644827
   REAL time: 2h 22min 41s 187ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: c01dc7bbae7789bbf992d827ce9fe662aeb17c79
CI: 64a5c905f307e2e98dbf9ad1d31e22d0eea08eed
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UsePublishedCrossgen2=false -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R /godata/pipelines/Release-CLR-QEMU/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
unknown command
# TESTFX_RUN
unknown command

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-VF2: 9440 / 9461 (99.78%)

=======================
      passed: 9440
      failed: 4
     skipped: 107
      killed: 17
------------------------
  TOTAL libs: 9568
 TOTAL tests: 9568
   REAL time: 2h 58min 45s 591ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 572716 / 609386 (93.98%)

=======================
      passed: 572716
      failed: 84
     skipped: 1452
      killed: 36586
------------------------
  TOTAL libs: 256
 TOTAL tests: 610838
   REAL time: 2h 40min 43s 79ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: c01dc7bbae7789bbf992d827ce9fe662aeb17c79
CI: 64a5c905f307e2e98dbf9ad1d31e22d0eea08eed
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UsePublishedCrossgen2=false -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R /var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
unknown command
# TESTFX_RUN
unknown command

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

tomeksowi

Some comments. Thanks for this bring-up!

src/coreclr/nativeaot/Runtime/MiscHelpers.cpp

src/coreclr/nativeaot/Runtime/PalRedhawk.h

src/coreclr/nativeaot/Runtime/unix/UnwindHelpers.cpp

src/coreclr/nativeaot/Runtime/unix/unixasmmacrosriscv64.inc

src/coreclr/nativeaot/Runtime/ThunksMapping.cpp

Co-authored-by: Tomek Sowiński <tomeksowi@gmail.com>

am11 · 2024-12-16T13:41:03Z

Thanks for the review @tomeksowi, I have addressed the feedback. 🙂

src/coreclr/nativeaot/Runtime/MiscHelpers.cpp

Co-authored-by: Tomasz Sowiński <tomeksowi@gmail.com>

src/coreclr/nativeaot/Runtime/riscv64/UniversalTransition.S

sirntar

Overall it looks good, I left some nitpicking comments, but the current solution is fine too. I don't see any more bugs other than those already pointed out by @tomeksowi
Anyway, thanks for this great contribution 🥉

*I will do additional tests later, but CI shows that there are no regressions.

src/coreclr/nativeaot/Runtime/MiscHelpers.cpp

src/coreclr/nativeaot/Runtime/riscv64/WriteBarriers.S

src/coreclr/nativeaot/Runtime/riscv64/PInvoke.S

src/coreclr/nativeaot/Runtime/riscv64/StubDispatch.S

sirntar · 2024-12-17T11:41:40Z

...LCompiler.Compiler/Compiler/DependencyAnalysis/Target_RiscV64/RiscV64ReadyToRunHelperNode.cs

+                            // Not tested
+                            encoder.EmitBreak();
+


looks correct, but I will test it manually later

Co-authored-by: Tymoteusz Wenerski <tymoteusz.wenerski@gmail.com>

tomeksowi

As a build unblocking PR it looks ok, we can fix more if/when we actually start using NativeAOT.

src/coreclr/nativeaot/Runtime/ThunksMapping.cpp

src/coreclr/nativeaot/Runtime/MiscHelpers.cpp

tomeksowi · 2024-12-17T13:43:58Z

src/coreclr/nativeaot/Runtime/unix/UnixNativeCodeManager.cpp

+    {
+        uint32_t instr = *pInstr;
+
+        if (((instr & STW_PAIR_MASK) == STW_PAIR_BITS) &&


Should be something like TrailingEpilogueInstructionsCount but detecting stores instead of loads.

Co-authored-by: Tomasz Sowiński <tomeksowi@gmail.com>

am11 · 2024-12-20T10:35:31Z

@jkotas please review this. Trying to avoid more merge conflicts emerging from new PRs.

am11 and others added 10 commits September 30, 2024 00:32

part1

3fa9946

part2

429e67c

part3

e0ef18b

Misc. fixes

3900943

Apply fixes from main

4cbecee

Fix registers/offsets in riscv-nativeaot.

8adbc73

Revert the changes in UnwindCursor.hpp and REGDISPLAY.

ec0776c

Fix *.S files in riscv-nativeaot.

6fce606

Merge dotnet/main into feature/nativeaot/riscv64-port

8b819a5

Fix riscv64 nativeaot native build

4dbe95c

dotnet-issue-labeler bot added the area-NativeAOT-coreclr label Dec 13, 2024

am11 requested review from filipnavara and a team December 13, 2024 11:46

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 13, 2024

Merge branch 'main' into feature/nativeaot/riscv64-port

e1fbc73

am11 added the arch-riscv Related to the RISC-V architecture label Dec 13, 2024

This was referenced Dec 13, 2024

[RISC-V] Fix HostActivation.Tests unknown-rid #110687

Open

Use live apphost when publishing ilc as singlefile #105004

Open

Managed build fixes

c01dc7b

build-analysis bot mentioned this pull request Dec 13, 2024

SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts dotnet/dnceng#2496

Open

3 tasks

am11 marked this pull request as ready for review December 13, 2024 15:03

am11 requested a review from MichalStrehovsky as a code owner December 13, 2024 15:03

tomeksowi reviewed Dec 16, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/ThunksMapping.cpp Outdated Show resolved Hide resolved

Address feedback

bd3641b

Co-authored-by: Tomek Sowiński <tomeksowi@gmail.com>

am11 force-pushed the feature/nativeaot/riscv64-port branch from a312a0f to bd3641b Compare December 16, 2024 13:37

tomeksowi reviewed Dec 16, 2024

View reviewed changes

Apply suggestions from code review

ddbb05e

Co-authored-by: Tomasz Sowiński <tomeksowi@gmail.com>

tomeksowi reviewed Dec 16, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/riscv64/UniversalTransition.S Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Dec 16, 2024

Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928

Open

3 tasks

Update src/coreclr/nativeaot/Runtime/riscv64/UniversalTransition.S

60f3f1d

build-analysis bot mentioned this pull request Dec 16, 2024

Nuget: Central Directory corrupt dotnet/dnceng#3099

Open

3 tasks

sirntar reviewed Dec 17, 2024

View reviewed changes

Apply suggestions from code review

03e4394

Co-authored-by: Tymoteusz Wenerski <tymoteusz.wenerski@gmail.com>

tomeksowi approved these changes Dec 17, 2024

View reviewed changes

Apply suggestions from code review

56e5a87

Co-authored-by: Tomasz Sowiński <tomeksowi@gmail.com>

sirntar approved these changes Dec 17, 2024

View reviewed changes

This was referenced Dec 17, 2024

The hosted runner encountered an error while running your job. (Error Type: Disconnect). dotnet/dnceng#1919

Open

[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090

Open

Merge branch 'main' into feature/nativeaot/riscv64-port

ef6d1d7

build-analysis bot mentioned this pull request Dec 17, 2024

restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879

Open

3 tasks

Merge branch 'main' into feature/nativeaot/riscv64-port

d006373

am11 force-pushed the feature/nativeaot/riscv64-port branch from 1850935 to d006373 Compare December 20, 2024 10:27

am11 mentioned this pull request Dec 20, 2024

Remove uses of DECODE_RETURN_KIND part of GCInfo #110799

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add linux-riscv64 nativeaot runtime build #110688

Add linux-riscv64 nativeaot runtime build #110688

am11 commented Dec 13, 2024

dotnet-policy-service bot commented Dec 13, 2024

clamp03 commented Dec 16, 2024

am11 commented Dec 16, 2024

risc-vv commented Dec 16, 2024 •

edited

Loading

risc-vv commented Dec 16, 2024 •

edited

Loading

tomeksowi left a comment

am11 commented Dec 16, 2024

sirntar left a comment

sirntar Dec 17, 2024

tomeksowi left a comment

tomeksowi Dec 17, 2024

am11 commented Dec 20, 2024

Add linux-riscv64 nativeaot runtime build #110688

Are you sure you want to change the base?

Add linux-riscv64 nativeaot runtime build #110688

Conversation

am11 commented Dec 13, 2024

dotnet-policy-service bot commented Dec 13, 2024

clamp03 commented Dec 16, 2024

am11 commented Dec 16, 2024

risc-vv commented Dec 16, 2024 • edited Loading

risc-vv commented Dec 16, 2024 • edited Loading

tomeksowi left a comment

Choose a reason for hiding this comment

am11 commented Dec 16, 2024

sirntar left a comment

Choose a reason for hiding this comment

sirntar Dec 17, 2024

Choose a reason for hiding this comment

tomeksowi left a comment

Choose a reason for hiding this comment

tomeksowi Dec 17, 2024

Choose a reason for hiding this comment

am11 commented Dec 20, 2024

risc-vv commented Dec 16, 2024 •

edited

Loading

risc-vv commented Dec 16, 2024 •

edited

Loading