-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux-riscv64 nativeaot runtime build #110688
Merged
Merged
Changes from 18 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3fa9946
part1
am11 429e67c
part2
am11 e0ef18b
part3
am11 3900943
Misc. fixes
am11 4cbecee
Apply fixes from main
am11 8adbc73
Fix registers/offsets in riscv-nativeaot.
sunlijun-610 ec0776c
Revert the changes in UnwindCursor.hpp and REGDISPLAY.
sunlijun-610 6fce606
Fix *.S files in riscv-nativeaot.
sunlijun-610 8b819a5
Merge dotnet/main into feature/nativeaot/riscv64-port
am11 4dbe95c
Fix riscv64 nativeaot native build
am11 e1fbc73
Merge branch 'main' into feature/nativeaot/riscv64-port
am11 c01dc7b
Managed build fixes
am11 bd3641b
Address feedback
am11 ddbb05e
Apply suggestions from code review
am11 60f3f1d
Update src/coreclr/nativeaot/Runtime/riscv64/UniversalTransition.S
am11 03e4394
Apply suggestions from code review
am11 56e5a87
Apply suggestions from code review
am11 ef6d1d7
Merge branch 'main' into feature/nativeaot/riscv64-port
am11 d006373
Merge branch 'main' into feature/nativeaot/riscv64-port
am11 71fb818
Merge branch 'main' into feature/nativeaot/riscv64-port
am11 b96fc63
Define GetReturnAddressRegisterLocation
am11 3949dfa
Fix merge conflict
am11 a33d91c
Update other macros in AsmOffsetsVerify
am11 c3c07cd
Update src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWrite…
jkotas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, this is producing message like:
static_assert failed: 'Bad asm offset for 'PAL_LIMITED_CONTEXT.Rbp'. Actual offset: offsetof(PAL_LIMITED_CONTEXT, Rbp)'
This is less informative message than the existing one that tries to tell you whether the actual offset is less or more. Why is it an improvement?
Also, if it is an improvement, should the other macros in this file get the same treatment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. I just changed the value of ExInfo and ran
build.sh -a loongarch64
in the container I was already running, it shows the actual computed value:It helped me figuring out a few issues during the port. I can update other macros as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not show the computed value with Windows compilers:
I am fine with changing it. All macros in the file should be changed the same way.