[RISC-V] coreclr-jit directory #82379

clamp03 · 2023-02-20T04:19:21Z

Successfully cross-build for RISC-V.
Run A simple application "helloworld"
Fail a test in clr.paltest

BruceForstall · 2023-02-20T05:15:00Z

@dotnet/jit-contrib

ghost · 2023-02-20T06:22:06Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Successfully cross-build for RISC-V.
Run A simple application "helloworld"
Fail a test in clr.paltest

Author:	clamp03
Assignees:	-
Labels:	`area-CodeGen-coreclr`, `community-contribution`, `arch-riscv`
Milestone:	-

src/coreclr/jit/codegenlinear.cpp

clamp03 · 2023-02-23T05:32:40Z

@dotnet/jit-contrib Could you review this PR? Actually I don't know why tests failed or cancelled.
If you leave any comment, I will update as possible as I can.
Thank you.

BruceForstall · 2023-02-23T06:04:44Z

@clamp03 As you know, this is a very large change and will take a significant amount of time and effort to review. We are discussing internally how to approach it, but no decisions have been made yet.

clamp03 · 2023-02-23T06:14:29Z

@BruceForstall Thank you for the comment. I can wait. :)

jakobbotsch

First quick pass.

@clamp03 can you please avoid force-pushing when you address feedback? It makes it very hard for reviewers to see what changed.

src/coreclr/jit/compiler.cpp

src/coreclr/jit/instr.h

src/coreclr/jit/unwind.h

src/coreclr/jit/valuenumfuncs.h

src/coreclr/jit/codegencommon.cpp

- Successfully cross-build for RISC-V. - Run A simple application "helloworld" - Fail a test in clr.paltest

src/coreclr/jit/codegenriscv64.cpp

jakobbotsch · 2023-04-05T15:04:19Z

src/coreclr/jit/gentree.cpp

@@ -24047,7 +24088,7 @@ void ReturnTypeDesc::InitializeStructReturnType(Compiler*                comp,
                m_regType[i] = comp->getJitGCType(gcPtrs[i]);
            }

-#elif defined(TARGET_LOONGARCH64)
+#elif defined(TARGET_LOONGARCH64) || defined(TARGET_RISCV64)
            assert((structSize >= TARGET_POINTER_SIZE) && (structSize <= (2 * TARGET_POINTER_SIZE)));

            uint32_t floatFieldFlags = comp->info.compCompHnd->getLoongArch64PassStructInRegisterFlags(retClsHnd);


Seems a bit odd to call getLoongArch64PassStructInRegisterFlags here, but I guess the ABIs are close enough/equivalent for this to work out?

Sorry. It is really odd even if these are very close. I created a new for RISCV64 and pushed a commit in both vm and jit PRs.
Thank you.

This also requires updating the JIT-EE GUID and ThunkInput.txt. See https://github.com/dotnet/runtime/blob/main/docs/project/updating-jitinterface.md for more details.

I don't think it is ok to leave it unimplemented on the VM side in this PR. Can you introduce a skeleton for this new JIT-EE API? If you need some more help then #78593 is an example PR that introduces a new JIT-EE API.

I already added ThunkInput.txt and the other codes into #82381. (*. I missed GUID update.)

If you think that all related codes should be in a PR, then how about reverting the last commit and make a new PR after this coreclr-jit and coreclr-vm (#82381) PR are merged?
If not, I will update GUID in #82381 and so on.
Thank you

The problem is that we cannot merge this PR without coherent JIT-EE implementations/consumptions for all our tooling. I would suggest adding the helper (including the VM side and the rest of the boilerplate) as part of this PR.

I moved coreclr-vm commit to this and updated GUID.
Thank you.

jakobbotsch · 2023-04-05T15:14:09Z

src/coreclr/jit/lowerriscv64.cpp

+            case GT_XOR:
+                return emitter::isValidUimm11(immVal);
+            case GT_JCMP:
+                assert(((parentNode->gtFlags & GTF_JCMP_TST) == 0) ? (immVal == 0) : isPow2(immVal));


Does RISC-V have the equivalent of ARM64's tbnz/tbz instructions?

Nope. In general, replace TNBZ Rt, #imm, label with SLLI tmp, Rt, 63-imm; BLTZ tmp, label and TBZ with the same but BGEZ. 2 byte instruction plus 4 byte branch instruction.

For imm in 0..10 you could use ANDI with 1<<imm, then BEQZ or BNEZ, which is a 4 byte instruction then a 2 byte branch... But it's the same size and performance anyway

@BruceForstall Thank you so much. Oops :)
@brucehoult Thank you so much!!

@brucehoult , that is :)

@brucehoult -- looks like you have lots of RISC-V experience. Maybe we'll see you contribute to the .NET implementation?

@brucehoult -- looks like you have lots of RISC-V experience.

Since you asked :-) I worked on the CoreCLR to Arm port at Samsung R&D Moscow in 2016, bought one of the first HIFive1 RISC-V boards in Jan 2017, then in early 2018 left Samsung to join RISC-V pioneers SiFive in San Mateo where I worked on runtime, compiler, emulator stuff and also contributed to designing the B and V extensions. (and less so others). You'll find my name in the credits for those extensions, plus the unprivileged ISA manual. Also co-moderator of /r/riscv on Reddit since December 2019, in which time we've grown it from 2500 to 14000 members.

Today was my last day at a New Zealand web dev company I've been working at during COVID. Looking at moving back into the RISC-V world now it's starting to explode. Have VisionFive 2 :-) Currently have ssh access to a 64 core 2.0 GHz OoO (similar to Cortex A72) SG2042 and doing a little vector 0.7.1 asm work on that for someone ... mmmm, tasty.

Thanks @brucehoult! Good luck in the RISC-V world :)

@clamp03 If there is no direct equivalent of tbnz/tbz then RISC-V should not be setting this GTF_JCMP_TST flag. Indeed, I can see that it is never set by LowerJTrue, so this part of the assert here is just dead code.

I removed the assert code in the last patch https://github.com/dotnet/runtime/pull/82379/commits/607dd64ec3dbefa2115317fccc95a6a3df483a14

jakobbotsch

LGTM with a couple of last questions! Thanks for the patience.

I will run some stress jobs just to ensure nothing else seems to be affected.

jakobbotsch · 2023-04-05T15:30:32Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2023-04-05T16:19:16Z

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch · 2023-04-08T18:30:21Z

@clamp03 Thanks again for the patience and for addressing all the feedback!

clamp03 · 2023-04-09T23:07:28Z

@jakobbotsch Thank you so much. I am really appreciate for your reviews and hard works.

ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 20, 2023

clamp03 mentioned this pull request Feb 20, 2023

Initial Patch for RISC-V support #82294

Closed

clamp03 changed the title ~~[RISCV-V] coreclr-jit directory~~ [RISC-V] coreclr-jit directory Feb 20, 2023

clamp03 mentioned this pull request Feb 20, 2023

RISC-V support #36748

Open

BruceForstall self-requested a review February 20, 2023 05:14

jkotas added arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Feb 20, 2023

build-analysis bot mentioned this pull request Feb 20, 2023

NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723

Open

5 tasks

jakobbotsch reviewed Feb 20, 2023

View reviewed changes

src/coreclr/jit/codegenlinear.cpp Outdated Show resolved Hide resolved

clamp03 force-pushed the riscv_jit branch 3 times, most recently from 908aab6 to 54a957f Compare February 22, 2023 03:10

build-analysis bot mentioned this pull request Feb 22, 2023

Tracking issue for CI build timeouts #76454

Closed

clamp03 force-pushed the riscv_jit branch 2 times, most recently from cc695d6 to a0983f2 Compare February 23, 2023 02:07

clamp03 force-pushed the riscv_jit branch from a0983f2 to 70c419b Compare March 7, 2023 02:27

jakobbotsch reviewed Mar 7, 2023

View reviewed changes

clamp03 added 8 commits March 8, 2023 14:36

[RISCV-V] coreclr-jit directory

15cf55b

- Successfully cross-build for RISC-V. - Run A simple application "helloworld" - Fail a test in clr.paltest

Fix in jit/CMakeLists.txt

f4aa536

Tidy up by jit-format

37f9519

Add a emitIns_S_R_R to handling more temporary reg

f3a7a41

Fix jit code format

521db1c

Fix

48c198c

[JIT] Fix test

8760646

[JIT] Updated

60d461d

jakobbotsch reviewed Apr 4, 2023

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

jakobbotsch reviewed Apr 4, 2023

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

clamp03 added 3 commits April 5, 2023 23:09

[JIT] Update by reviews

618978a

[JIT] Update JCMP and fix related errors

cec6fa0

[JIT] Add NYI

db341cc

jakobbotsch reviewed Apr 5, 2023

View reviewed changes

jakobbotsch approved these changes Apr 5, 2023

View reviewed changes

[JIT] Add getRISCV64PassStructInRegisterFlags

607dd64

jakobbotsch added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 6, 2023

clamp03 mentioned this pull request Apr 6, 2023

[RISC-V] coreclr-vm and other directories in coreclr #82381

Merged

clamp03 added 3 commits April 6, 2023 19:31

[JIT] Remove constant handling in genRangeCheck

6492c51

[VM] Add getRISCV64PassStructInRegisterFlags

f06eef5

[VM] Update JITEEVersionIdentifier

672629a

clamp03 requested a review from MichalStrehovsky as a code owner April 6, 2023 10:36

clamp03 and others added 2 commits April 6, 2023 20:35

Merge remote-tracking branch 'upstream/main' into riscv_jit

f25d760

Run jit-format

718b6d9

build-analysis bot mentioned this pull request Apr 6, 2023

WindowsServiceLifetimeTests.ServiceCanStopItself fails in CI #84438

Closed

jakobbotsch added 2 commits April 8, 2023 17:33

Merge branch 'main' of github.com:dotnet/runtime into pr-82379

b94ebc5

Fix after merge

f39aaa3

jakobbotsch merged commit 6ca0784 into dotnet:main Apr 8, 2023

clamp03 deleted the riscv_jit branch April 9, 2023 23:07

clamp03 mentioned this pull request Apr 9, 2023

[RISC-V] coreclr-pal and coreclr-debug directories #82380

Merged

gbalykov mentioned this pull request Apr 14, 2023

CoreCLR RISC-V architecture port #84834

Open

7 tasks

ghost locked as resolved and limited conversation to collaborators May 10, 2023

clamp03 self-assigned this Sep 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RISC-V] coreclr-jit directory #82379

[RISC-V] coreclr-jit directory #82379

clamp03 commented Feb 20, 2023

BruceForstall commented Feb 20, 2023

ghost commented Feb 20, 2023

clamp03 commented Feb 23, 2023

BruceForstall commented Feb 23, 2023

clamp03 commented Feb 23, 2023

jakobbotsch left a comment

jakobbotsch Apr 5, 2023

clamp03 Apr 6, 2023

jakobbotsch Apr 6, 2023

jakobbotsch Apr 6, 2023

clamp03 Apr 6, 2023

jakobbotsch Apr 6, 2023

clamp03 Apr 6, 2023

jakobbotsch Apr 5, 2023

brucehoult Apr 6, 2023

clamp03 Apr 6, 2023 •

edited

Loading

BruceForstall Apr 6, 2023

brucehoult Apr 6, 2023

jakobbotsch Apr 6, 2023 •

edited

Loading

clamp03 Apr 6, 2023

jakobbotsch left a comment

jakobbotsch commented Apr 5, 2023

azure-pipelines bot commented Apr 5, 2023

jakobbotsch commented Apr 8, 2023

clamp03 commented Apr 9, 2023

[RISC-V] coreclr-jit directory #82379

[RISC-V] coreclr-jit directory #82379

Conversation

clamp03 commented Feb 20, 2023

BruceForstall commented Feb 20, 2023

ghost commented Feb 20, 2023

clamp03 commented Feb 23, 2023

BruceForstall commented Feb 23, 2023

clamp03 commented Feb 23, 2023

jakobbotsch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

clamp03 Apr 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakobbotsch Apr 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakobbotsch left a comment

Choose a reason for hiding this comment

jakobbotsch commented Apr 5, 2023

azure-pipelines bot commented Apr 5, 2023

jakobbotsch commented Apr 8, 2023

clamp03 commented Apr 9, 2023

clamp03 Apr 6, 2023 •

edited

Loading

jakobbotsch Apr 6, 2023 •

edited

Loading