Skip deeply-recursive test in System.Runtime.Serialization.Xml.ReflectionOnly.Tests if doing random OSR
#106335
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 13, 2024
amanasifkhalid
changed the title
System.Runtime.Serialization.Xml.ReflectionOnly.Tests if doing random OSR
amanasifkhalid
commented
Aug 13, 2024
| @@ -4477,8 +4477,11 @@ public static void DCS_TypeWithPrimitiveKnownTypes() | |||
| Assert.NotNull(actual); | |||
| } | |||
|
|
|||
| // Random OSR might cause a stack overflow on Windows x64 | |||
| private static bool IsNotWindowsRandomOSR => !PlatformDetection.IsWindows || (Environment.GetEnvironmentVariable("DOTNET_JitRandomOnStackReplacement") == null); | |||
|
|
|||
| [SkipOnPlatform(TestPlatforms.Browser, "Causes a stack overflow")] | |||
There was a problem hiding this comment.
I probably should've noticed this hint earlier...
|
@AndyAyersMS PTAL, the last |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100246. Disables test that frequently overflows the stack for OSR stress scenarios (see comment for discussion).