Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip deeply-recursive test in System.Runtime.Serialization.Xml.ReflectionOnly.Tests if doing random OSR #106335

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Skip deeply-recursive test in System.Runtime.Serialization.Xml.ReflectionOnly.Tests if doing random OSR #106335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd1c9ec
Skip test if doing random OSR
amanasifkhalid Aug 13, 2024
59885f4
Revert
amanasifkhalid Aug 13, 2024
148b94b
Use ConditionalFact
amanasifkhalid Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4477,8 +4477,11 @@ public static void DCS_TypeWithPrimitiveKnownTypes()
Assert.NotNull(actual);
}

// Random OSR might cause a stack overflow on Windows x64
private static bool IsNotWindowsRandomOSR => !PlatformDetection.IsWindows || (Environment.GetEnvironmentVariable("DOTNET_JitRandomOnStackReplacement") == null);

[SkipOnPlatform(TestPlatforms.Browser, "Causes a stack overflow")]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably should've noticed this hint earlier...

[Fact]
[ConditionalFact(nameof(IsNotWindowsRandomOSR))]
public static void DCS_DeeplyLinkedData()
{
TypeWithLinkedProperty head = new TypeWithLinkedProperty();
Expand Down
Loading