-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Clean emsdk setup #106403
base: main
Are you sure you want to change the base?
[wasm] Clean emsdk setup #106403
Conversation
I have a problem with native build on Windows.
so when it executes I have to find a way to append required variables to
edit: |
…\emsdk\emscripten\.emscripten"
…mscripten\.emscripten"
… $(EmscriptenPythonToolsPath)".
…mand" + ensure node path is formatted correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
command build and run to reproduce (
Edit: |
Fixes #105439.
This PR is enhanced version of previous attempt of cleanup done in 2 PRs: in emsdk: dotnet/emsdk#851 and runtime: #105612. What it does:
emsdk_env*
scriptEMSDK_PATH
locationpre_emsdk_env
(better names are welcome)Justification of changes in
EmSdkRepo.Defaults.props
:WasmApp.InTree.props
was not successful - the.props
file is imported too late to matter in the stage of checking if node / python paths are set.WasmApp.InTree.targets
would require a workaround that would make the target run before_SetupEmscripten
task and also beforeEmSdkRepo.Defaults.props
import that is "caching" an error about python path on Windows. Such a workaround would not be as straightforward as setting the paths inEmSdkRepo.Defaults.props
.