Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests fails on CI #107381

Closed
buyaa-n opened this issue Sep 4, 2024 · 15 comments · Fixed by #107433
Labels
area-GC-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' in-pr There is an active PR which will close this issue when it is merged Known Build Error Use this to report build issues in the .NET Helix tab
Milestone

Comments

@buyaa-n
Copy link
Member

buyaa-n commented Sep 4, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=797859
Build error leg or test failing: Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind_Key_Instance
Pull request: #106781

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "System.OutOfMemoryException : Insufficient memory to continue the execution of the program.",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=797859
Error message validated: [System.OutOfMemoryException : Insufficient memory to continue the execution of the program.]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 9/4/2024 11:39:25 PM UTC

Report

Build Definition Test Pull Request
799289 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.GetValue_NamedParametersOutOfOrder #107431
799092 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.InvalidRootMethodInputTypes #107426
799211 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #107385
799151 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #107378
799144 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #106309
799125 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #107427
799119 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.InvalidRootMethodInputTypes #107266
799104 dotnet/runtime System.Text.Json.SourceGeneration.UnitTests.JsonSourceGeneratorDiagnosticsTests.MultiDimensionArrayDoesNotProduceWarnings
799099 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.GetValue_T_Key #107395
799096 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.InvalidRootMethodInputTypes #107316
799066 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.CannotDetermineTypeInfo #107424
798962 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.MinimalGenerationIfNoBindableMembers #107410
798924 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Configure_T_NamedParameters_OutOfOrder #107366
798869 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.SucceedWhenGivenMinimumRequiredReferences #107408
798865 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #106900
798858 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #107395
797591 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind_NamedParameters_OutOfOrder #107333
798840 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.InvalidRootMethodInputTypes #107378
798784 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind #107403
798751 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.BindConfigurationWithConfigureActions #107402
798725 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.InvalidRootMethodInputTypes #106403
798667 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.GetValue_T_Key #107368
798609 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind_T_BinderOptions #106875
798578 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Configure_T_name_BinderOptions #107028
798571 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.BindConfigurationWithConfigureActions #107291
798550 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.CannotDetermineTypeInfo #107264
798481 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.GetValue_T_Key #107395
798478 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.InvalidRootMethodInputTypes #107365
798436 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.CannotDetermineTypeInfo #107390
798421 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #107389
798418 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #107351
798389 dotnet/runtime System.Text.Json.SourceGeneration.UnitTests.JsonSourceGeneratorIncrementalTests.CompilingTheSameSourceResultsInEqualModels
798347 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #105427
798274 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #107385
797804 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #107368
798212 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get #107278
798182 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Bind_T_NamedParameters_OutOfOrder #105771
797909 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_PrimitivesOnly #107009
797898 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Configure_T_name_BinderOptions #107372
798102 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Get_TypeOf_NamedParametersOutOfOrder #107378
798015 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Configure_T_NamedParameters_OutOfOrder #107376
797859 dotnet/runtime Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests.Configure_T_NamedParameters_OutOfOrder #106781

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
37 42 42
@buyaa-n buyaa-n added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Sep 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Sep 4, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@buyaa-n buyaa-n changed the title Many ConfigurationBindingGeneratorTests fails on CI Many Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests fails on CI Sep 4, 2024
@buyaa-n buyaa-n changed the title Many Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests fails on CI Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBindingGeneratorTests fails on CI Sep 4, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

@tarekgh
Copy link
Member

tarekgh commented Sep 5, 2024

This is the first time I have seen such failure. My guess is the running machine was in a bad state which couldn't even allocate native memory. We'll watch if we see the failure again soon.

@buyaa-n did you try to re-run this failed test in PR after you saw it failed? or you just logged the issue?

CC @ericstj

@tarekgh tarekgh added this to the 10.0.0 milestone Sep 5, 2024
@tarekgh tarekgh removed the untriaged New issue has not been triaged by the area owner label Sep 5, 2024
@tarekgh
Copy link
Member

tarekgh commented Sep 5, 2024

Seeing the same failure in other PRs #107009.

@buyaa-n
Copy link
Member Author

buyaa-n commented Sep 5, 2024

@buyaa-n did you try to re-run this failed test in PR after you saw it failed?

Tried rerun in another PR, did not help

@tarekgh
Copy link
Member

tarekgh commented Sep 5, 2024

Actually in another PR, rerun made the test pass. will watch that and find out what is going on.

@buyaa-n
Copy link
Member Author

buyaa-n commented Sep 5, 2024

Actually in another PR, rerun made the test pass. will watch that and find out what is going on.

Ah, for me it just added to the known build errors instead succeed.

@ericstj
Copy link
Member

ericstj commented Sep 5, 2024

Such a high recent hit count does signal a real problem here. We should have a look and see if we can bisect what caused the regression.

@tarekgh
Copy link
Member

tarekgh commented Sep 5, 2024

I have done git bisect and isolated the commit that started causing the regression. @elinor-fung could you please have a look? Looks your change started to cause this OOM problem (specifically on x86). Thanks!

commit 815509cb9dba9fe72adc11119c2336e916a92966
Author: Elinor Fung <elfung@microsoft.com>
Date:   Wed Sep 4 07:23:26 2024 -0700

    Put handling of sized ref handles under FEATURE_SIZED_REF_HANDLES (#107326)

 src/coreclr/debug/daccess/dacdbiimpl.cpp |  7 -------
 src/coreclr/debug/daccess/dacimpl.h      |  2 +-
 src/coreclr/debug/daccess/request.cpp    |  3 +--
 src/coreclr/gc/gc.cpp                    | 13 +++++++++++--
 src/coreclr/gc/gcinterface.h             |  2 ++
 src/coreclr/gc/gcscan.cpp                |  2 ++
 src/coreclr/gc/gcscan.h                  |  3 ++-
 src/coreclr/gc/handletableconstants.h    |  1 +
 src/coreclr/gc/objecthandle.cpp          | 25 ++++++++++++++++++++++---
 src/coreclr/vm/gchandleutilities.h       | 17 -----------------
 src/coreclr/vm/marshalnative.cpp         |  2 +-
 src/coreclr/vm/runtimehandles.cpp        |  2 +-
 12 files changed, 44 insertions(+), 35 deletions(-)

@tarekgh tarekgh added area-GC-coreclr untriaged New issue has not been triaged by the area owner and removed area-Extensions-Configuration labels Sep 5, 2024
@tarekgh tarekgh modified the milestones: 10.0.0, 9.0.0 Sep 5, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Sep 5, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

@tarekgh tarekgh added the untriaged New issue has not been triaged by the area owner label Sep 5, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Sep 5, 2024
@mangod9 mangod9 modified the milestones: 9.0.0, 10.0.0 Sep 5, 2024
@mangod9
Copy link
Member

mangod9 commented Sep 5, 2024

@tarekgh, assume this in main and not in 9 branches?

@tarekgh
Copy link
Member

tarekgh commented Sep 5, 2024

assume this in main and not in 9 branches?

That is right. We are seeing the failure in main and not in 9 release branch.

@mangod9
Copy link
Member

mangod9 commented Sep 5, 2024

ok just making sure since it was moved to 9 milestone. @elinor-fung, please take a look and maybe revert since its causing many CI failures?

@elinor-fung
Copy link
Member

Looking. Will revert if I don't find what the issue is today.

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Sep 5, 2024
@elinor-fung
Copy link
Member

PR that should fix this: #107433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-GC-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' in-pr There is an active PR which will close this issue when it is merged Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
5 participants