Empty slice fix #107316
Merged
Empty slice fix #107316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Sep 4, 2024
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 4, 2024
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 4, 2024
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 4, 2024
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 4, 2024
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 4, 2024
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 4, 2024
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 4, 2024
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorSpan.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 4, 2024
michaelgsharp
force-pushed
the
empy-slice
branch
from
568f93e
to
a1a5318
Compare
This was referenced Sep 11, 2024
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
Outdated
Show resolved
Hide resolved
| } | ||
| else | ||
| { | ||
| lengths = new nint[Rank]; | ||
| offsets = new nint[Rank]; | ||
| lengths = stackalloc nint[Rank]; |
There was a problem hiding this comment.
not something to fix in this PR, but dynamically lengthed stackalloc is "bad"
Rather we should be using MaxInlineRank and slicing down to Rank
There was a problem hiding this comment.
Sounds good. Why is dynamically lengthed stackalloc bad?
There was a problem hiding this comment.
Because it results in a lot of additional codegen to handle the fact the length is "unknown". Since we know the maximum is small, its better to do that and slice to avoid the pessimization.
Otherwise, it typically ends up cheaper to just use the array pool; rather than stackalloc at all.
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs
Outdated
Show resolved
Hide resolved
tannergooding
approved these changes
Sep 16, 2024
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10889237560 |
4 tasks
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
* empty slice fix * PR comments and more testing * fixing check * fixing array rent init * fixes from PR comments
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* empty slice fix * PR comments and more testing * fixing check * fixing array rent init * fixes from PR comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106536. When slicing an empty
Tensor, you should be able to ask for..and get back an empty tensor. This PR enables this behavior.