Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Microsoft.Private.Intellisense version to 9.0.0-preview-20240830.1 #107424

Closed

Conversation

carlossanlop
Copy link
Member

@dotnet/runtime-infrastructure @dotnet/area-infrastructure-libraries PTAL

This package versiopn was freshly updated today:
https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet9-transport/NuGet/Microsoft.Private.Intellisense/overview/9.0.0-preview-20240830.1

More updates will come in the next weeks.

Will backport to release/9.0.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member Author

carlossanlop commented Sep 5, 2024

@dotnet/source-build-internal I am updating the version of a package that runtime needs to ensure we ship the latest intellisense xml files. I intend to backport this to the release/9.0 branch too.

Unfortunately, the CI is showing an error saying this is a prebuilt: https://github.com/dotnet/runtime/pull/107424/checks?check_run_id=29750201383

.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24423.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.Private.Intellisense.9.0.0-preview-20240830.1

Should I add it as an exception to eng/SourceBuildPrebuiltBaseline.xml in runtime as it is suggested in https://aka.ms/dotnet/prebuilts ? Or should I do something else?

@ellahathaway
Copy link
Member

Should I add it as an exception to eng/SourceBuildPrebuiltBaseline.xml in runtime as it is suggested in https://aka.ms/dotnet/prebuilts ? Or should I do something else?

Looks like the 8.0 version is in SBRP: https://github.com/dotnet/dotnet/tree/main/src/source-build-reference-packages/src/textOnlyPackages/src/microsoft.private.intellisense

To resolve this prebuilt, you'll have to add the 9.0 version to SBRP and then wait for the SBRP dependency version to be updated in runtime.

@ellahathaway
Copy link
Member

ellahathaway commented Sep 5, 2024

Here's a link to a PR from last year that bumped the version: dotnet/source-build-reference-packages#774

@carlossanlop
Copy link
Member Author

Here's a link to a PR from last year that bumped the version: dotnet/source-build-reference-packages#774

Oh thanks, I had forgotten about this.

@MichaelSimons
Copy link
Member

Reminder that improving this UX is tracked with #77004.

@carlossanlop
Copy link
Member Author

Here's the PR with the deps flow that will unblock this: #107256

@carlossanlop
Copy link
Member Author

Since I just triggered the code flow PRs from SBRP, I can just edit those instead of updating this branch, rerruning the CI, and wasting time and resources.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries blocked Issue/PR is blocked on something - see comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants