Target .NET 10 / net10.0 #106599
Merged
Target .NET 10 / net10.0 #106599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
needs-area-label
lewing
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
to be able to build System.Text.Json on net9.0.
akoeplinger
reviewed
Aug 19, 2024
...libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj
Show resolved
Hide resolved
3 tasks
|
@ViktorHofer I already had this PR open for this purpose: #106421 |
am11
reviewed
Sep 24, 2024
am11
reviewed
Sep 24, 2024
am11
reviewed
Sep 24, 2024
|
Lets revert the fork pointer, since the branch is merged. |
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
|
|
lewing
requested review from
marek-safar,
maraf,
ilonatommy,
lewing,
pavelsavara and
MichalStrehovsky
as code owners
|
BA is green! 🍏 |
ericstj
approved these changes
Sep 24, 2024
| @@ -22,16 +22,16 @@ From within the utility directory, run the utility with the arguments: | |||
|
|
|||
| For example: | |||
| ``` | |||
| dotnet run d:\output "d:\repos\runtime\artifacts\bin\testhost\net6.0-windows-Debug-x64\shared\Microsoft.NETCore.App\5.0.0" "d:\repos\runtime\artifacts\bin\System.Runtime.Tests\net6.0-windows-Debug\System.Runtime.Tests.dll" | |||
| dotnet run d:\output "d:\repos\runtime\artifacts\bin\testhost\net10.0-windows-Debug-x64\shared\Microsoft.NETCore.App\5.0.0" "d:\repos\runtime\artifacts\bin\System.Runtime.Tests\net10.0-windows-Debug\System.Runtime.Tests.dll" | |||
There was a problem hiding this comment.
these ones probably didn't need to change 😆
There was a problem hiding this comment.
Probably incorrect in main as well net6.0\...\5.0.0, maybe with last part 10.0.0, it makes a good double-digit example? (.net 6 will be out of support in Nov.)
There was a problem hiding this comment.
I didn't even notice that other version in the path -- you're right that's wrong as well. Seems OK to update this just give it a deeper review for correctness.
| @@ -1,14 +1,10 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>netstandard2.0;netstandard2.1;$(NetFrameworkMinimum);$(NetCoreAppMinimum);$(NetCoreAppCurrent)</TargetFrameworks> | |||
| <TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks> | |||
There was a problem hiding this comment.
You cannot drop netstandard2.1 from this package. That's breaking and the cause of the compatibility error being suppressed.
| @@ -127,4 +127,130 @@ | |||
| <Right>lib/netstandard2.0/System.Numerics.Tensors.dll</Right> | |||
| <IsBaselineSuppression>true</IsBaselineSuppression> | |||
| </Suppression> | |||
| <Suppression> | |||
| <DiagnosticId>CP0017</DiagnosticId> | |||
| <Target>M:System.Numerics.Tensors.Tensor.GreaterThanOrEqualAll``1(System.Numerics.Tensors.ReadOnlyTensorSpan{``0}@,``0)$0</Target> | |||
There was a problem hiding this comment.
If you wanted to update to use RC1 baseline this would go away. That can be done separately.
There was a problem hiding this comment.
We should be now, this was probably done before then. misunderstood
There was a problem hiding this comment.
Referring to updating this version to RC1 : https://github.com/dotnet/runtime/pull/106599/files#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16eR125
<ApiCompatNetCoreAppBaselineVersion>9.0.0-preview.7.24405.7</ApiCompatNetCoreAppBaselineVersion>
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* Update dotnet10 feeds * Update hardcoded old TFM values * More hardcode updates and TFM checks * Updates and delete duplicate file in Bcl.Numerics * Linker stays on net9.0 * Fix .NET SDK max supported version * Update apicompat sfx apicompat baseline file * Update Microsoft.NET.WebAssembly.Threading APICompat settings * Fix DiagnosticSource build * Update SDK to RC1 for needed GetAlternateLookup API to be able to build System.Text.Json on net9.0. * Fix APICompat runtime regex pattern * Suppress Bcl.Memory compatibility error for dropped framework * Fix BinaryFormatter tests regex pattern for version subsitution * Update BinaryFormatterTests.cs * Pin SdkVersionForWorkloadTesting to the version in global.json * Treat net9 and net10 as current for now * Bump MicrosoftDotNetILCompilerVersion * Update BinaryFormatterTests.cs * Update System.Resources.Extensions * Update AutoImports as well * Fix ImporterTests.cs * Block failing SignalRClientTests * Update XmlSerialzation Schema Import tests. * Update Versions.props * Update CompatibilitySuppressions.xml for System.Numerics.Tensors * Don't set EnableDefaultCompileItems, it doesn't work since we set EnableDefaultItems=false higher up * Update regex in legacy BinaryFormatterTests.cs too * Hardcode BinaryFormatter test assembly version to 9.0 This allows us to not change the majority of the tests * Fix typo * Fix issue in Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest.pkgproj * Replace ForceNet8Current in a few more places * Fix wasi workload * Fix TreatAsCurrent for 10.0 * Add net9 workload manifests * Update PackageId in icrosoft.NET.Runtime.WebAssembly.Templates.csproj * Update ApiCompatBaseline.NetCoreAppLatestStable.xml Changes from dotnet#107758 * Remove duplicate dotnet10 feeds from nuget.config * Update Versions.props * Fake SDK band version for now * Update Versions.props * Update the SDK band versions for real * Update the dotnet/sdk dependencies * Update emsdk to net10 workloads * Install a 9.0 runtime for workload tests too * Update the compat tasks * Merge in changes from net10-manifests * Tmp: Trying out @am11's branch. * Tmp2: Trying out @am11's branch. * Tmp3: Replace the last usage of main in clone action. * Update eng/pipelines/coreclr/templates/build-perf-bdn-app.yml Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Update eng/pipelines/coreclr/templates/perf-job.yml Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Update eng/pipelines/runtime-wasm-perf.yml Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Jackson Schuster <36744439+jtschuster@users.noreply.github.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com> Co-authored-by: Steve Molloy <smolloy@microsoft.com> Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #105343