Arm64/Sve: Remove entries of SVE APIs take 32-bit address #107758
Merged
+164
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
1 similar comment
|
Note regarding the |
|
@dotnet/arm64-contrib |
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
amanasifkhalid
approved these changes
Sep 12, 2024
This was referenced Sep 13, 2024
|
/ba-g failure seems to be timeout |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10842874058 |
|
@kunalspathak backporting to release/9.0 failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Remove entry of APIs because of #103297
Using index info to reconstruct a base tree...
M src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs
M src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs
CONFLICT (content): Merge conflict in src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs
CONFLICT (content): Merge conflict in src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Remove entry of APIs because of #103297
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@kunalspathak an error occurred while backporting to release/9.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
kunalspathak
added a commit
to kunalspathak/runtime
that referenced
this pull request
Sep 13, 2024
) * Remove entry of APIs because of dotnet#103297 * comment out the test cases for unsupported APIs
4 tasks
kunalspathak
added a commit
to kunalspathak/runtime
that referenced
this pull request
Sep 13, 2024
) * Remove entry of APIs because of dotnet#103297 * comment out the test cases for unsupported APIs
akoeplinger
added a commit
to ViktorHofer/runtime
that referenced
this pull request
Sep 13, 2024
jeffschwMSFT
added a commit
that referenced
this pull request
Sep 13, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
) * Remove entry of APIs because of dotnet#103297 * comment out the test cases for unsupported APIs
lewing
added a commit
that referenced
this pull request
Sep 25, 2024
* Update dotnet10 feeds * Update hardcoded old TFM values * More hardcode updates and TFM checks * Updates and delete duplicate file in Bcl.Numerics * Linker stays on net9.0 * Fix .NET SDK max supported version * Update apicompat sfx apicompat baseline file * Update Microsoft.NET.WebAssembly.Threading APICompat settings * Fix DiagnosticSource build * Update SDK to RC1 for needed GetAlternateLookup API to be able to build System.Text.Json on net9.0. * Fix APICompat runtime regex pattern * Suppress Bcl.Memory compatibility error for dropped framework * Fix BinaryFormatter tests regex pattern for version subsitution * Update BinaryFormatterTests.cs * Pin SdkVersionForWorkloadTesting to the version in global.json * Treat net9 and net10 as current for now * Bump MicrosoftDotNetILCompilerVersion * Update BinaryFormatterTests.cs * Update System.Resources.Extensions * Update AutoImports as well * Fix ImporterTests.cs * Block failing SignalRClientTests * Update XmlSerialzation Schema Import tests. * Update Versions.props * Update CompatibilitySuppressions.xml for System.Numerics.Tensors * Don't set EnableDefaultCompileItems, it doesn't work since we set EnableDefaultItems=false higher up * Update regex in legacy BinaryFormatterTests.cs too * Hardcode BinaryFormatter test assembly version to 9.0 This allows us to not change the majority of the tests * Fix typo * Fix issue in Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest.pkgproj * Replace ForceNet8Current in a few more places * Fix wasi workload * Fix TreatAsCurrent for 10.0 * Add net9 workload manifests * Update PackageId in icrosoft.NET.Runtime.WebAssembly.Templates.csproj * Update ApiCompatBaseline.NetCoreAppLatestStable.xml Changes from #107758 * Remove duplicate dotnet10 feeds from nuget.config * Update Versions.props * Fake SDK band version for now * Update Versions.props * Update the SDK band versions for real * Update the dotnet/sdk dependencies * Update emsdk to net10 workloads * Install a 9.0 runtime for workload tests too * Update the compat tasks * Merge in changes from net10-manifests * Tmp: Trying out @am11's branch. * Tmp2: Trying out @am11's branch. * Tmp3: Replace the last usage of main in clone action. * Update eng/pipelines/coreclr/templates/build-perf-bdn-app.yml Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Update eng/pipelines/coreclr/templates/perf-job.yml Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Update eng/pipelines/runtime-wasm-perf.yml Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Jackson Schuster <36744439+jtschuster@users.noreply.github.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com> Co-authored-by: Steve Molloy <smolloy@microsoft.com> Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
) * Remove entry of APIs because of dotnet#103297 * comment out the test cases for unsupported APIs
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* Update dotnet10 feeds * Update hardcoded old TFM values * More hardcode updates and TFM checks * Updates and delete duplicate file in Bcl.Numerics * Linker stays on net9.0 * Fix .NET SDK max supported version * Update apicompat sfx apicompat baseline file * Update Microsoft.NET.WebAssembly.Threading APICompat settings * Fix DiagnosticSource build * Update SDK to RC1 for needed GetAlternateLookup API to be able to build System.Text.Json on net9.0. * Fix APICompat runtime regex pattern * Suppress Bcl.Memory compatibility error for dropped framework * Fix BinaryFormatter tests regex pattern for version subsitution * Update BinaryFormatterTests.cs * Pin SdkVersionForWorkloadTesting to the version in global.json * Treat net9 and net10 as current for now * Bump MicrosoftDotNetILCompilerVersion * Update BinaryFormatterTests.cs * Update System.Resources.Extensions * Update AutoImports as well * Fix ImporterTests.cs * Block failing SignalRClientTests * Update XmlSerialzation Schema Import tests. * Update Versions.props * Update CompatibilitySuppressions.xml for System.Numerics.Tensors * Don't set EnableDefaultCompileItems, it doesn't work since we set EnableDefaultItems=false higher up * Update regex in legacy BinaryFormatterTests.cs too * Hardcode BinaryFormatter test assembly version to 9.0 This allows us to not change the majority of the tests * Fix typo * Fix issue in Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest.pkgproj * Replace ForceNet8Current in a few more places * Fix wasi workload * Fix TreatAsCurrent for 10.0 * Add net9 workload manifests * Update PackageId in icrosoft.NET.Runtime.WebAssembly.Templates.csproj * Update ApiCompatBaseline.NetCoreAppLatestStable.xml Changes from dotnet#107758 * Remove duplicate dotnet10 feeds from nuget.config * Update Versions.props * Fake SDK band version for now * Update Versions.props * Update the SDK band versions for real * Update the dotnet/sdk dependencies * Update emsdk to net10 workloads * Install a 9.0 runtime for workload tests too * Update the compat tasks * Merge in changes from net10-manifests * Tmp: Trying out @am11's branch. * Tmp2: Trying out @am11's branch. * Tmp3: Replace the last usage of main in clone action. * Update eng/pipelines/coreclr/templates/build-perf-bdn-app.yml Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Update eng/pipelines/coreclr/templates/perf-job.yml Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Update eng/pipelines/runtime-wasm-perf.yml Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Jackson Schuster <36744439+jtschuster@users.noreply.github.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com> Co-authored-by: Steve Molloy <smolloy@microsoft.com> Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have done it in the past because we do not have good way of validating them. There were few left over that I commented in this PR and disabled the tests for them.