[release/9.0] Fix storage of stack trace of exception from reflection #107093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was one more case where we have saved the stack trace into the _remoteStackTraceString field in the exception when the exception was passing from reflection invoked code to the caller of that code. While there is no visible difference in the Exception.ToString, a SOS test was failing due to that. And it is not necessary to save the stack trace there. I have thought about the cases when we really need the stack trace saved into the _remoteStackTraceString and I believe that actually the only case is when an existing exception is thrown again in managed code. So I have removed the option to save the stack trace from all the variants of the DispatchManagedException.
jeffschwMSFT
approved these changes
Aug 28, 2024
jeffschwMSFT
added
Servicing-approved
jkotas
approved these changes
Aug 28, 2024
This was referenced Aug 28, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106901 to release/9.0
/cc @janvorli
Customer Impact
The issue prevents SOS showing correct stack trace for inner exceptions when the exception occurs in reflection invoked code and when it is propagated to the caller of the reflected code.
Regression
The regression was caused by enabling of the new exception handling by default.
Testing
Tested using a SOS test that was failing and also manually with a testing application and WinDbg.
Risk
Low. There is no visible change for getting the exception stack trace using
Exception.ToString, it only influences SOS.