Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Fix storage of stack trace of exception from reflection #107093

Merged
merged 3 commits into from
Aug 29, 2024

Commits on Aug 28, 2024

  1. Fix storage of stack trace of exception from reflection

    There was one more case where we have saved the stack trace into the _remoteStackTraceString
    field in the exception when the exception was passing from reflection invoked code
    to the caller of that code. While there is no visible difference in the Exception.ToString,
    a SOS test was failing due to that. And it is not necessary to save the stack trace
    there.
    
    I have thought about the cases when we really need the stack trace saved into the
    _remoteStackTraceString and I believe that actually the only case is when an existing
    exception is thrown again in managed code. So I have removed the option to save the stack
    trace from all the variants of the DispatchManagedException.
    janvorli authored and github-actions committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ed5a55a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    3a72f46 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed4e8d4 View commit details
    Browse the repository at this point in the history