Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable annotate System.Security.Cryptography.Cng #32039

Merged
merged 7 commits into from
Feb 14, 2020
Merged

Nullable annotate System.Security.Cryptography.Cng #32039

merged 7 commits into from
Feb 14, 2020

Conversation

eiriktsarpalis
Copy link
Member

Contributes to #2339

@eiriktsarpalis eiriktsarpalis added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 10, 2020
@eiriktsarpalis
Copy link
Member Author

I missed that annotation work for System.Security.Cryptography.Algorithms hasn't been merged yet (#2375). Holding off until that is done.

@eiriktsarpalis eiriktsarpalis force-pushed the annotate-system-security-cryptography-cng branch from 8448e1a to 726b318 Compare February 11, 2020 13:49
@eiriktsarpalis eiriktsarpalis removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 11, 2020
bartonjs
bartonjs reviewed Feb 11, 2020
View reviewed changes
src/libraries/Common/src/Internal/Cryptography/HashProviderCng.cs Outdated Show resolved Hide resolved
src/libraries/Common/src/Interop/Windows/BCrypt/BCryptAlgorithmCache.cs Outdated Show resolved Hide resolved
src/libraries/Common/src/Interop/Windows/BCrypt/BCryptAlgorithmCache.cs Outdated Show resolved Hide resolved
src/libraries/Common/src/Interop/Windows/BCrypt/Interop.BCryptOpenAlgorithmProvider.cs Outdated Show resolved Hide resolved
src/libraries/System.Security.Cryptography.Cng/src/System/Security/Cryptography/CngKey.EC.cs Show resolved Hide resolved
...ystem.Security.Cryptography.Cng/src/System/Security/Cryptography/CngKeyCreationParameters.cs Outdated Show resolved Hide resolved
...ystem.Security.Cryptography.Cng/src/System/Security/Cryptography/CngKeyCreationParameters.cs Outdated Show resolved Hide resolved
@eiriktsarpalis eiriktsarpalis force-pushed the annotate-system-security-cryptography-cng branch from 4f71527 to 0ed07ab Compare February 12, 2020 12:13
@eiriktsarpalis
Copy link
Member Author

This should be ready to go in.

This was referenced Feb 12, 2020
Closed
Closed
@eiriktsarpalis eiriktsarpalis force-pushed the annotate-system-security-cryptography-cng branch from 0ed07ab to b141ed3 Compare February 13, 2020 10:53
@eiriktsarpalis eiriktsarpalis self-assigned this Feb 13, 2020
@eiriktsarpalis eiriktsarpalis force-pushed the annotate-system-security-cryptography-cng branch from 77037eb to b141ed3 Compare February 13, 2020 15:16
buyaa-n
buyaa-n approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few NIT comments, overall LGTM

@eiriktsarpalis eiriktsarpalis force-pushed the annotate-system-security-cryptography-cng branch from a67731c to 887f164 Compare February 14, 2020 15:33
@eiriktsarpalis eiriktsarpalis merged commit 7d65b33 into dotnet:master Feb 14, 2020
@eiriktsarpalis eiriktsarpalis deleted the annotate-system-security-cryptography-cng branch February 14, 2020 17:45
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartonjs bartonjs bartonjs left review comments

@buyaa-n buyaa-n buyaa-n approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eiriktsarpalis @bartonjs @buyaa-n @Dotnet-GitSync-Bot