Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to empty RuntimeHelpers.PrepareConstrainedRegions() #33191

Merged
merged 4 commits into from
Mar 16, 2020
Merged

Remove calls to empty RuntimeHelpers.PrepareConstrainedRegions() #33191

merged 4 commits into from
Mar 16, 2020

Conversation

Marusyk
Copy link
Member

@Marusyk Marusyk commented Mar 4, 2020 •
edited
Loading

Remove calls to empty RuntimeHelpers.PrepareConstrainedRegions()

Issue #33179

Skipped (please let me know if need some action on these):

Please review,
Thank you in advance

@stephentoub
Copy link
Member

The ones under src/coreclr/src/System.Private.CoreLib/src should be fine to remove.

@Marusyk
Copy link
Member Author

Marusyk commented Mar 15, 2020

what is the reason of failed builds?

@stephentoub
Copy link
Member

what is the reason of failed builds?

A seg fault in a variety of coreclr tests on Linux. I don't think it's related to your PR, but I'm running the tests again.

stephentoub
stephentoub approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jkotas
Copy link
Member

jkotas commented Mar 16, 2020

The Linux failures are known issue fixed by #33580

@jkotas jkotas merged commit 8f99208 into dotnet:master Mar 16, 2020
@Marusyk Marusyk deleted the marusyk/PrepareConstrainedRegions branch March 16, 2020 15:52
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger left review comments

@tmat tmat tmat left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Marusyk @stephentoub @jkotas @tmat @akoeplinger @danmoseley @Dotnet-GitSync-Bot